8295919: java.security.MessageDigest.isEqual does not adhere to @implNote

[driverkt]

Fix JDK-8295919 by updating the javadoc to explain that a null or zero-length digestb will also result in a short-circuit response

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295919: java.security.MessageDigest.isEqual does not adhere to @implNote (Bug - P4)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15933/head:pull/15933
$ git checkout pull/15933

Update a local copy of the PR:
$ git checkout pull/15933
$ git pull https://git.openjdk.org/jdk.git pull/15933/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15933

View PR using the GUI difftool:
$ git pr show -t 15933

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15933.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@driverkt The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (07ad68e0)
• 01: Full - Incremental (17ed6c71)
• 00: Full (0ee35d9d)

[seanjmullan]

Looks good.

Please add a noreg-doc label to the bug.

[openjdk]

@driverkt This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295919: java.security.MessageDigest.isEqual does not adhere to @implNote

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• 5a6aa56: 8303959: tools/jpackage/share/RuntimePackageTest.java fails with java.lang.AssertionError missing files
• 014c95a: 8317126: Redundant entries in Windows tzmappings file
• fa0697a: 8316998: Remove redundant type arguments in the java.util.stream package
• 49376e4: 8316000: File.setExecutable silently fails if file does not exist
• a185be0: 8317139: [JVMCI] oop handles clearing message pollutes event log
• 179792b: 8317283: jpackage tests run osx-specific checks on windows and linux
• bd918f4: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
• c45308a: 8301327: convert assert to guarantee in Handle_IDiv_Exception
• bd7bb67: 8317257: RISC-V: llvm build broken
• 0259da9: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
• ... and 46 more: https://git.openjdk.org/jdk/compare/36ac83904c9e81a01822b0e36ef677cae2808709...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[driverkt]

/integrate

[openjdk]

Going to push as commit 47569a2.
Since your change was applied there have been 56 commits pushed to the master branch:

• 5a6aa56: 8303959: tools/jpackage/share/RuntimePackageTest.java fails with java.lang.AssertionError missing files
• 014c95a: 8317126: Redundant entries in Windows tzmappings file
• fa0697a: 8316998: Remove redundant type arguments in the java.util.stream package
• 49376e4: 8316000: File.setExecutable silently fails if file does not exist
• a185be0: 8317139: [JVMCI] oop handles clearing message pollutes event log
• 179792b: 8317283: jpackage tests run osx-specific checks on windows and linux
• bd918f4: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
• c45308a: 8301327: convert assert to guarantee in Handle_IDiv_Exception
• bd7bb67: 8317257: RISC-V: llvm build broken
• 0259da9: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
• ... and 46 more: https://git.openjdk.org/jdk/compare/36ac83904c9e81a01822b0e36ef677cae2808709...master

Your commit was automatically rebased without conflicts.

[openjdk]

@driverkt Pushed as commit 47569a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.