Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306630: Bump minimum boot jdk to JDK 21 #15934

Closed
wants to merge 1 commit into from

Conversation

vidmik
Copy link
Member

@vidmik vidmik commented Sep 26, 2023

With the JDK 21 GA out it's time to bump the minimum boot JDK version for mainline/JDK 22.

Testing: tier1-5, GHA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306630: Bump minimum boot jdk to JDK 21 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15934/head:pull/15934
$ git checkout pull/15934

Update a local copy of the PR:
$ git checkout pull/15934
$ git pull https://git.openjdk.org/jdk.git pull/15934/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15934

View PR using the GUI difftool:
$ git pr show -t 15934

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15934.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2023

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Sep 26, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 26, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306630: Bump minimum boot jdk to JDK 21

Reviewed-by: darcy, erikj, iris, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • d3a79b5: 8316371: Open some swing tests 6
  • 750da00: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
  • 5350fd6: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization
  • edcc559: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
  • 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • 347bd15: 8315966: Relativize initial_sp in interpreter frames
  • b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
  • ad6df41: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
  • ... and 23 more: https://git.openjdk.org/jdk/compare/be9cc73fcad0cac0a6f12b0f962fbe3bd8328ec9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 26, 2023
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

@vidmik
Copy link
Member Author

vidmik commented Sep 28, 2023

Thank you for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit 83c0e45.
Since your change was applied there have been 33 commits pushed to the master branch:

  • d3a79b5: 8316371: Open some swing tests 6
  • 750da00: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
  • 5350fd6: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization
  • edcc559: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
  • 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • 347bd15: 8315966: Relativize initial_sp in interpreter frames
  • b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
  • ad6df41: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
  • ... and 23 more: https://git.openjdk.org/jdk/compare/be9cc73fcad0cac0a6f12b0f962fbe3bd8328ec9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@vidmik Pushed as commit 83c0e45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants