8316946: jtreg failure handler pages are mislabelling the jcmd/thread/dump_to_file results.

[jaikiran]

Can I please get a review of this change which addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8316946?

Failure handler actions can specify a "successArtifacts" property value, which are file name(s) for which hypherlinks will be created in the "processes.html" file. This property value can contain replacable placeholder tokens like "%p" (process id) "%iterCount" (iteration count, if the action's command is repeated).

The issue here was caused by a bug in the handling of the "successArtifacts" value. If there were more than one process for which we were running the action (of collecting thread dumps), then the original (raw) value of "successArtifacts" property wasn't being held on to. As a result, for the second process for which the hyperlink was being created, an incorrect link would be generated.

The commit here retains the raw value of "successArtifacts" property in the PatternAction (just like we do for "args" property) so that it can be used to repeatedly replace the placeholders, each time the action is run for a different process.

I've run this change against our internal CI to verify it doesn't cause any regressions. tier1, tier2 and tier3 was run successfully. Additionally, I have run a couple of jtreg test cases which intentionally timeout, so that I can verify that the generated "processes.html" now contains the correct hyperlinks to the thread dump files for each process.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8316946: jtreg failure handler pages are mislabelling the jcmd/thread/dump_to_file results. (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15939/head:pull/15939
$ git checkout pull/15939

Update a local copy of the PR:
$ git checkout pull/15939
$ git pull https://git.openjdk.org/jdk.git pull/15939/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15939

View PR using the GUI difftool:
$ git pr show -t 15939

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15939.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f64a2003)

[dholmes-ora]

Based on the description this change looks good.

Thanks.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316946: jtreg failure handler pages are mislabelling the jcmd/thread/dump_to_file results.

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 750da00: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
• b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
• 5350fd6: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization
• edcc559: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
• 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
• 347bd15: 8315966: Relativize initial_sp in interpreter frames
• b24ad7c: 8316924: java/lang/Thread/virtual/stress/ParkALot.java times out
• ad6df41: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
• 45a145e: 8299915: Remove ArrayAllocatorMallocLimit and associated code
• 50a7a04: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists
• ... and 5 more: https://git.openjdk.org/jdk/compare/2f311d59dcbbf7605e52fac0b8ebd35d7d51a48b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Thank you David for the review.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 42924ed.
Since your change was applied there have been 20 commits pushed to the master branch:

• 384d2ea: 8316125: Windows call_stub unnecessarily saves xmm16-31 when UseAVX>=3
• 84390dd: 8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently
• 52073b2: 8316994: Avoid modifying ClassLoader and Module objects during -Xshare:dump
• 83c0e45: 8306630: Bump minimum boot jdk to JDK 21
• d3a79b5: 8316371: Open some swing tests 6
• 750da00: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
• b8cec48: 8315848: G1: Rename rs_ prefix to card_rs in analytics
• 5350fd6: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization
• edcc559: 8316661: CompilerThread leaks CodeBlob memory when dynamically stopping compiler thread in non-product
• 1be3557: 8315721: CloseRace.java#id0 fails transiently on libgraal
• ... and 10 more: https://git.openjdk.org/jdk/compare/2f311d59dcbbf7605e52fac0b8ebd35d7d51a48b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 42924ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.