-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316924: java/lang/Thread/virtual/stress/ParkALot.java times out #15940
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@@ -87,7 +88,7 @@ private static void parkALot(int iterations) { | |||
if (state == Thread.State.WAITING || state == Thread.State.TIMED_WAITING) { | |||
LockSupport.unpark(vthread); | |||
} else { | |||
Thread.onSpinWait(); | |||
Thread.yield(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit b24ad7c.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit b24ad7c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A test only change to a stress test for virtual thread parking/unparking to limit execution time on a larger systems. Right run, the test bashes parking/unparking for 1, 2, 3, ... up to the number of half the hardware threads. It is changed to limit it to 4 iterations. It is also dialed down for debug builds as they may run with -XX:+VerifyContinuations which is an expensive assert (but an important one for tests like that).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15940/head:pull/15940
$ git checkout pull/15940
Update a local copy of the PR:
$ git checkout pull/15940
$ git pull https://git.openjdk.org/jdk.git pull/15940/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15940
View PR using the GUI difftool:
$ git pr show -t 15940
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15940.diff
Webrev
Link to Webrev Comment