Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317034: Remove redundant type cast in the java.util.stream package #15942

Closed
wants to merge 3 commits into from

Conversation

mabbay
Copy link
Member

@mabbay mabbay commented Sep 27, 2023

Remove redundant type cast in the java.util.stream package.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317034: Remove redundant type cast in the java.util.stream package (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15942/head:pull/15942
$ git checkout pull/15942

Update a local copy of the PR:
$ git checkout pull/15942
$ git pull https://git.openjdk.org/jdk.git pull/15942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15942

View PR using the GUI difftool:
$ git pr show -t 15942

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15942.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2023

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@mabbay The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 27, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2023

Webrevs

@mabbay mabbay changed the title 8317034: Redundant type cast 8317034: Remove redundant type cast in the java.util.stream package Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317034: Remove redundant type cast in the java.util.stream package

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 355811a: 8316559: Refactor some util/Calendar tests to JUnit
  • ecb5e8a: 8317264: Pattern.Bound has static fields that should be static final.
  • f2c221d: 8317119: Remove unused imports in the java.util.stream package
  • 09dad0e: 8313810: BoxLayout uses
    instead of list for layout options
  • 73a47f0: 4622866: javax.swing.text.Document.remove(int, int) has a misleading picture
  • cfcbfc6: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
  • ca5eee2: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless
  • 060db1b: 8315031: YoungPLABSize and OldPLABSize not aligned by ObjectAlignmentInBytes
  • 3481a48: 8316974: ListFormat creation is unsuccessful for some of the supported Locales
  • 29348b3: 8316894: make test TEST="jtreg:test/jdk/..." fails on AIX
  • ... and 32 more: https://git.openjdk.org/jdk/compare/2f311d59dcbbf7605e52fac0b8ebd35d7d51a48b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@PaulSandoz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2023
@mabbay
Copy link
Member Author

mabbay commented Sep 29, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2023
@openjdk
Copy link

openjdk bot commented Sep 29, 2023

@mabbay
Your change (at version 89daab6) is now ready to be sponsored by a Committer.

@PaulSandoz
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 2, 2023

Going to push as commit ad81abd.
Since your change was applied there have been 70 commits pushed to the master branch:

  • d7d1d42: 8316771: Krb5.java has not defined messages for all error codes
  • f985006: 8309356: Read files in includedir in alphanumeric order
  • a564d43: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 878d27d: 8317273: compiler/codecache/OverflowCodeCacheTest.java fails transiently on Graal
  • 2637e8d: 8317314: Remove unimplemented ObjArrayKlass::oop_oop_iterate_elements_bounded
  • 8093563: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously
  • 516cfb1: 8316907: Fix nonnull-compare warnings
  • 5984792: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • eeb63cd: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
  • 6948942: 8317327: Remove JT_JAVA dead code in jib-profiles.js
  • ... and 60 more: https://git.openjdk.org/jdk/compare/2f311d59dcbbf7605e52fac0b8ebd35d7d51a48b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 2, 2023
@openjdk openjdk bot closed this Oct 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 2, 2023
@openjdk
Copy link

openjdk bot commented Oct 2, 2023

@PaulSandoz @mabbay Pushed as commit ad81abd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants