8310727: C2: *_of() methods in PhaseIterGVN should use uint for the node index

[dlunde]

This changeset addresses the below.

Some *_of() methods in PhaseIterGVN like replace_input_of() use int instead of uint for the node index. We should change that.

Testing (on all Oracle-supported platforms)

• tier1
• HotSpot parts of tier2 and tier3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8310727: C2: *_of() methods in PhaseIterGVN should use uint for the node index (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15946/head:pull/15946
$ git checkout pull/15946

Update a local copy of the PR:
$ git checkout pull/15946
$ git pull https://git.openjdk.org/jdk.git pull/15946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15946

View PR using the GUI difftool:
$ git pr show -t 15946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15946.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @dlunde, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dlunde" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@dlunde The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dlunde]

/covered

[dlunde]

Reason for covered: I'm an Oracle employee

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 00: Full (5cde402f)

[TobiHartmann]

Looks good (and trivial) to me.

[openjdk]

@dlunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310727: C2: *_of() methods in PhaseIterGVN should use uint for the node index

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• a57ae7e: 8317594: G1: Refactor find_empty_from_idx_reverse

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dlunde]

/integrate

[openjdk]

@dlunde
Your change (at version 5cde402) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 7ff1938.
Since your change was applied there has been 1 commit pushed to the master branch:

• a57ae7e: 8317594: G1: Refactor find_empty_from_idx_reverse

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @dlunde Pushed as commit 7ff1938.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.