Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm #15948

Closed
wants to merge 1 commit into from

Conversation

lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Sep 27, 2023

Use createTestJvm.

Tested with: -XX+UseG1GC (pass 1), -XX+UseZGC (total 0), -XX:G1ConcMarkStepDurationMillis=23 (total 0) and no options (pass 1)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15948/head:pull/15948
$ git checkout pull/15948

Update a local copy of the PR:
$ git checkout pull/15948
$ git pull https://git.openjdk.org/jdk.git pull/15948/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15948

View PR using the GUI difftool:
$ git pr show -t 15948

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15948.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2023

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8317042 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm Sep 27, 2023
@lkorinth lkorinth changed the title 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm Sep 27, 2023
@lkorinth lkorinth changed the title G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@lkorinth The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review labels Sep 27, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 1, 2023

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm

Reviewed-by: mli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

  • b6a97c0: 8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880
  • 287b243: 8316893: Compile without -fno-delete-null-pointer-checks
  • 26c21f5: 8314294: Unsafe::allocateMemory and Unsafe::freeMemory are slower than malloc/free
  • 6e1aacd: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • d2e2c4c: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry
  • e25121d: 8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries
  • 5c8366e: 8268622: Performance issues in javac Name class
  • ad81abd: 8317034: Remove redundant type cast in the java.util.stream package
  • d7d1d42: 8316771: Krb5.java has not defined messages for all error codes
  • f985006: 8309356: Read files in includedir in alphanumeric order
  • ... and 113 more: https://git.openjdk.org/jdk/compare/c24c66db97a52371875a63862f85ea5c2010d5a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2023
@lkorinth
Copy link
Contributor Author

Thanks Hamlin and Thomas!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit 7e39e66.
Since your change was applied there have been 290 commits pushed to the master branch:

  • 75b37e6: 8317218: G1: Make TestG1HeapRegionSize use createTestJvm
  • 34653c1: 8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id
  • d8cd605: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
  • 8f79d88: 8318155: Remove unnecessary virtual specifier in Space
  • b2b8db6: 8318180: Memory model reference from foreign package-info is broken
  • 5bd1052: 8317317: G1: Make TestG1RemSetFlags use createTestJvm
  • c64bd3d: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 6ee6171: 8317347: Parallel: Make TestInitialTenuringThreshold use createTestJvm
  • 7ca0ae9: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • 5521560: 8310673: [JVMCI] batch compilation for libgraal should work the same way as for C2
  • ... and 280 more: https://git.openjdk.org/jdk/compare/c24c66db97a52371875a63862f85ea5c2010d5a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@lkorinth Pushed as commit 7e39e66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants