8317139: [JVMCI] oop handles clearing message pollutes event log

[dougxc]

The message for the event of clearing oop handles after each libjvmci compilation should only be logged at level 2 (i.e. -XX:JVMCIEventLogLevel=2 or -XX:JVMCITraceLevel=2). Otherwise, it crowds out more useful events in hs-err crash logs. For example:

JVMCI Events (20 events):
Event: 0.853 Thread 0x00007fdde0002470 compacted oop handles in JVMCI runtime 4 from 94 to 68
Event: 0.853 Thread 0x00007fde0002e6d0 compacted oop handles in JVMCI runtime 2 from 102 to 63
Event: 0.855 Thread 0x00007fde0002e6d0 compacted oop handles in JVMCI runtime 2 from 70 to 69
Event: 0.856 Thread 0x00007fdde0002470 compacted oop handles in JVMCI runtime 4 from 71 to 70
Event: 0.861 Thread 0x00007fdde0002470 compacted oop handles in JVMCI runtime 4 from 78 to 77
Event: 0.866 Thread 0x00007fde0002e6d0 compacted oop handles in JVMCI runtime 2 from 82 to 81
Event: 0.870 Thread 0x00007fded01824f0 compacted oop handles in JVMCI runtime 0 from 88 to 85
Event: 0.875 Thread 0x00007fdde0002470 compacted oop handles in JVMCI runtime 4 from 91 to 90
Event: 0.876 Thread 0x00007fded01824f0 compacted oop handles in JVMCI runtime 0 from 86 to 52
Event: 0.878 Thread 0x00007fde0002d2f0 compacted oop handles in JVMCI runtime 1 from 69 to 65
Event: 0.897 Thread 0x00007fde0002e6d0 compacted oop handles in JVMCI runtime 2 from 101 to 99
Event: 0.897 Thread 0x00007fde0002e6d0 compacted oop handles in JVMCI runtime 2 from 100 to 70
Event: 0.897 Thread 0x00007fdde00037f0 compacted oop handles in JVMCI runtime 3 from 99 to 66
Event: 0.902 Thread 0x00007fde0002e6d0 compacted oop handles in JVMCI runtime 2 from 71 to 70
Event: 0.916 Thread 0x00007fde0002d2f0 compacted oop handles in JVMCI runtime 1 from 78 to 62
Event: 0.916 Thread 0x00007fdde00037f0 compacted oop handles in JVMCI runtime 3 from 81 to 79
Event: 0.919 Thread 0x00007fdde0002470 compacted oop handles in JVMCI runtime 4 from 100 to 80
Event: 0.922 Thread 0x00007fde0002d2f0 compacted oop handles in JVMCI runtime 1 from 70 to 69
Event: 0.923 Thread 0x00007fdde0002470 compacted oop handles in JVMCI runtime 4 from 85 to 84
Event: 0.926 Thread 0x00007fded01824f0 compacted oop handles in JVMCI runtime 0 from 77 to 74

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317139: [JVMCI] oop handles clearing message pollutes event log (Enhancement - P4)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15956/head:pull/15956
$ git checkout pull/15956

Update a local copy of the PR:
$ git checkout pull/15956
$ git pull https://git.openjdk.org/jdk.git pull/15956/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15956

View PR using the GUI difftool:
$ git pr show -t 15956

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15956.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9b7f5006)

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317139: [JVMCI] oop handles clearing message pollutes event log

Reviewed-by: never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• c45308a: 8301327: convert assert to guarantee in Handle_IDiv_Exception
• bd7bb67: 8317257: RISC-V: llvm build broken
• 0259da9: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
• 355811a: 8316559: Refactor some util/Calendar tests to JUnit
• ecb5e8a: 8317264: Pattern.Bound has static fields that should be static final.
• f2c221d: 8317119: Remove unused imports in the java.util.stream package
• 09dad0e: 8313810: BoxLayout uses

  instead of list for layout options

• 73a47f0: 4622866: javax.swing.text.Document.remove(int, int) has a misleading picture
• cfcbfc6: 8316879: RegionMatches1Tests fails if CompactStrings are disabled after JDK-8302163
• ca5eee2: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless
• ... and 20 more: https://git.openjdk.org/jdk/compare/750da0012931656cfd55f3e67c3f49ad7363ab8e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me too.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit a185be0.
Since your change was applied there have been 32 commits pushed to the master branch:

• 179792b: 8317283: jpackage tests run osx-specific checks on windows and linux
• bd918f4: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock"
• c45308a: 8301327: convert assert to guarantee in Handle_IDiv_Exception
• bd7bb67: 8317257: RISC-V: llvm build broken
• 0259da9: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session
• 355811a: 8316559: Refactor some util/Calendar tests to JUnit
• ecb5e8a: 8317264: Pattern.Bound has static fields that should be static final.
• f2c221d: 8317119: Remove unused imports in the java.util.stream package
• 09dad0e: 8313810: BoxLayout uses

  instead of list for layout options

• 73a47f0: 4622866: javax.swing.text.Document.remove(int, int) has a misleading picture
• ... and 22 more: https://git.openjdk.org/jdk/compare/750da0012931656cfd55f3e67c3f49ad7363ab8e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit a185be0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.