Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly #15961

Closed
wants to merge 5 commits into from

Conversation

ravigupta30
Copy link
Contributor

@ravigupta30 ravigupta30 commented Sep 28, 2023

Write a test to check textArea triggers MouseEntered/MouseExited events properly

MouseEntered should be triggered only when the mouse enters the component and MouseExited should be triggered when the mouse goes out of the component.

In TextArea, when we moved the mouse inside the component MouseMoved events are triggered properly. But when we slowly took the mouse outside the component that is towards the scrollbars, we could see a MouseEntered event being triggered followed by MouseExited.(before actually mouse enters the scrollbar)

Testing:
Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15961/head:pull/15961
$ git checkout pull/15961

Update a local copy of the PR:
$ git checkout pull/15961
$ git pull https://git.openjdk.org/jdk.git pull/15961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15961

View PR using the GUI difftool:
$ git pr show -t 15961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15961.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2023

👋 Welcome back ravigupta30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@ravigupta30 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 28, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2023

Webrevs

@ravigupta30
Copy link
Contributor Author

Any volunteers for a review?

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there source code fix or PR associated with this test. Since the PR description mentions "MouseEntered/Exited" events does not occur properly.

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes look good.

@aivanov-jdk
Copy link
Member

Is there source code fix or PR associated with this test.

I couldn't see the answer to this question. I guess the fix was done long time ago in JDK-4454304. Now, the test gets open-sourced.

@honkar-jdk
Copy link
Contributor

Is there source code fix or PR associated with this test.

I couldn't see the answer to this question. I guess the fix was done long time ago in JDK-4454304. Now, the test gets open-sourced.

Correct, and saw @ravigupta30 comments in JBS after this post.

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

⚠️ @ravigupta30 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8316947
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@ravigupta30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly

Reviewed-by: tr, honkar, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 171 new commits pushed to the master branch:

  • 731fb4e: 8317797: G1: Remove unimplemented predict_will_fit
  • 7976151: 8313438: [s390x] build broken after JDK-8301996
  • ca96fd3: 8317839: Exclude java/nio/channels/Channels/SocketChannelStreams.java on AIX
  • a9b41da: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 0fd8071: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic"
  • 1161e3d: 8317803: Exclude java/net/Socket/asyncClose/Race.java on AIX
  • e55c482: 8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX
  • 84b7cc1: 8317761: Combine two versions of print_statistics() in java.cpp
  • 3aa4cba: 8316975: Memory leak in MTLSurfaceData
  • 54861df: 8317802: jmh tests fail with Unable to find the resource: /META-INF/BenchmarkList after JDK-8306819
  • ... and 161 more: https://git.openjdk.org/jdk/compare/52983ed529182901db4e33857bfeab2727e235df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TejeshR13, @honkar-jdk, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2023
@ravigupta30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@ravigupta30
Your change (at version e5e1818) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

Going to push as commit 00ef9f9.
Since your change was applied there have been 187 commits pushed to the master branch:

  • 77dc891: 8317963: Serial: Remove unused GenerationIsInReservedClosure
  • d95b548: 8315850: Improve AbstractMap anonymous Iterator classes
  • 424de29: 8317866: replace NET_SocketAvailable
  • 6d6c900: 8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()
  • eca6ea4: 8317873: Add @sealedGraph to IllegalFormatException
  • 2edf9c3: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR
  • 839cb19: 8317581: [s390x] Multiple test failure with LockingMode=2
  • 387896f: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
  • 8d2ad2b: 8317977: update problemlist to include MacOS for sun/security/tools/keytool/NssTest.java
  • b92de54: 8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751
  • ... and 177 more: https://git.openjdk.org/jdk/compare/52983ed529182901db4e33857bfeab2727e235df...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2023
@openjdk openjdk bot closed this Oct 12, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 12, 2023
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@aivanov-jdk @ravigupta30 Pushed as commit 00ef9f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants