8317273: compiler/codecache/OverflowCodeCacheTest.java fails transiently on Graal

[dougxc]

This PR changes JVMCI to throw a BailoutException instead of causing a VM fatal error when a JVMCI RuntimeStub cannot be allocated in the CodeCache.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317273: compiler/codecache/OverflowCodeCacheTest.java fails transiently on Graal (Bug - P3)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer) ⚠️ Review applies to 6ca0cc1a
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15970/head:pull/15970
$ git checkout pull/15970

Update a local copy of the PR:
$ git checkout pull/15970
$ git pull https://git.openjdk.org/jdk.git pull/15970/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15970

View PR using the GUI difftool:
$ git pr show -t 15970

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15970.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a96d6390)
• 01: Full - Incremental (fa625f1a)
• 00: Full (6ca0cc1a)

[tkrodriguez]

looks good.

[tkrodriguez]

JDK-8289632 was closed as not an issue since RuntimeStubs are never freed in normal execution so maybe drop this comment.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317273: compiler/codecache/OverflowCodeCacheTest.java fails transiently on Graal

Reviewed-by: never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 2637e8d: 8317314: Remove unimplemented ObjArrayKlass::oop_oop_iterate_elements_bounded
• 8093563: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously
• 516cfb1: 8316907: Fix nonnull-compare warnings
• 5984792: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
• eeb63cd: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• 6948942: 8317327: Remove JT_JAVA dead code in jib-profiles.js
• 795e5dc: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration
• 207819a: 8315604: IGV: dump and visualize node bottom and phase types
• 8fcf70e: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes
• 93f662f: 8317335: Build on windows fails after 8316645
• ... and 2 more: https://git.openjdk.org/jdk/compare/009f5e1fa177eea326aefec0f995f589a01169d2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks reasonable to me.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit 878d27d.
Since your change was applied there have been 12 commits pushed to the master branch:

• 2637e8d: 8317314: Remove unimplemented ObjArrayKlass::oop_oop_iterate_elements_bounded
• 8093563: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously
• 516cfb1: 8316907: Fix nonnull-compare warnings
• 5984792: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
• eeb63cd: 8316361: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN with -XX:VerifyIterativeGVN=10
• 6948942: 8317327: Remove JT_JAVA dead code in jib-profiles.js
• 795e5dc: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration
• 207819a: 8315604: IGV: dump and visualize node bottom and phase types
• 8fcf70e: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes
• 93f662f: 8317335: Build on windows fails after 8316645
• ... and 2 more: https://git.openjdk.org/jdk/compare/009f5e1fa177eea326aefec0f995f589a01169d2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 878d27d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.