8255845: Memory leak in imageFile.cpp

[evwhelan]

This is a straightforward fix to resolve a potential memory leak in imageFile.cpp.

If find_location returns true, the path char array is never released.

This has been fixed

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255845: Memory leak in imageFile.cpp

Reviewers

• Jim Laskey (@JimLaskey - Reviewer)
• Athijegannathan Sundararajan (@sundararajana - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1599/head:pull/1599
$ git checkout pull/1599

[bridgekeeper]

👋 Welcome back ewhelan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@evwhelan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• 2d
• awt
• beans
• build
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah
• sound
• swing

[evwhelan]

/label core-libs

[openjdk]

@evwhelan
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 00: Full (5266ad4)

[openjdk]

@evwhelan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255845: Memory leak in imageFile.cpp

Reviewed-by: jlaskey, sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• fa58671: 8257020: [JVMCI] enable a JVMCICompiler to specify which GCs it supports
• 129c377: 8257594: C2 compiled checkcast of non-null object triggers endless deoptimization/recompilation cycle
• e4497c9: 8256718: Obsolete the long term deprecated and aliased Trace flags

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JimLaskey, @sundararajana) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[evwhelan]

/integrate

[openjdk]

@evwhelan
Your change (at version 5266ad4) is now ready to be sponsored by a Committer.

[JimLaskey]

/sponsor

[openjdk]

@JimLaskey @evwhelan Since your change was applied there have been 3 commits pushed to the master branch:

• fa58671: 8257020: [JVMCI] enable a JVMCICompiler to specify which GCs it supports
• 129c377: 8257594: C2 compiled checkcast of non-null object triggers endless deoptimization/recompilation cycle
• e4497c9: 8256718: Obsolete the long term deprecated and aliased Trace flags

Your commit was automatically rebased without conflicts.

Pushed as commit 66a2e70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.