Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException #15991

Closed
wants to merge 4 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Sep 29, 2023

The change #15501 removed explicit throwing of a FileAlreadyExistsException in copyToForeignTarget for non-directories when the target exists and REPLACE_EXISTING is not specified, instead relying on FileChannel.open eventually to throw this exception. The test, however, reuses the same file path, and on Windows CreateFile, which is invoked by open, can throw an AccessDeniedException if the file exists and has been marked for deletion but not yet actually deleted. This change proposes to reinstate explicitly throwing a FAEE.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15991/head:pull/15991
$ git checkout pull/15991

Update a local copy of the PR:
$ git checkout pull/15991
$ git pull https://git.openjdk.org/jdk.git pull/15991/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15991

View PR using the GUI difftool:
$ git pr show -t 15991

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15991.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2023
@openjdk
Copy link

openjdk bot commented Sep 29, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Sep 29, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 2, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException

Reviewed-by: alanb, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 991ce84: 4964430: (spec) missing IllegalStateException exception requirement for javax.crypto.Cipher.doFinal
  • 8a30c2a: 8317443: StackOverflowError on calling ListFormat::getInstance() for Norwegian locales
  • a1c9587: 8313348: Fix typo in JFormattedTextField: 'it self'
  • a8eacb3: 8317240: Promptly free OopMapEntry after fail to insert the entry to OopMapCache
  • 4c5b66d: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong
  • 42be238: 8316523: Relativize esp in interpreter frames (PowerPC only)
  • a250ae4: 8317039: Enable specifying the JDK used to run jtreg
  • 1ed9c76: 8309204: Obsolete DoReserveCopyInSuperWord
  • 3630af2: 8316594: C2 SuperWord: wrong result with hand unrolled loops
  • c6c69b5: 8314654: Metaspace: move locking out of MetaspaceArena
  • ... and 86 more: https://git.openjdk.org/jdk/compare/83c0e4516064846c956d9a760338e71be1593f6f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 2, 2023
@bplb bplb requested a review from AlanBateman October 4, 2023 23:45
Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks Ok to me

@bplb
Copy link
Member Author

bplb commented Oct 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

Going to push as commit 6c6beba.
Since your change was applied there have been 103 commits pushed to the master branch:

  • b62e774: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long
  • a64794b: 8317560: Change to Xcode 14.3.1 for building on macOS at Oracle
  • b3cc0c8: 8317318: Serial: Change GenCollectedHeap to SerialHeap in whitebox
  • 691db5d: 8317592: Serial: Remove Space::toContiguousSpace
  • ec9ba5d: 8317660: [BACKOUT] 8269393: store/load order not preserved when handling memory pool due to weakly ordered memory architecture of aarch64
  • 7162624: 8269393: store/load order not preserved when handling memory pool due to weakly ordered memory architecture of aarch64
  • f0d66d1: 8317502: Add asserts to check for non-null in ciInstance::java_lang_Class_klass
  • 991ce84: 4964430: (spec) missing IllegalStateException exception requirement for javax.crypto.Cipher.doFinal
  • 8a30c2a: 8317443: StackOverflowError on calling ListFormat::getInstance() for Norwegian locales
  • a1c9587: 8313348: Fix typo in JFormattedTextField: 'it self'
  • ... and 93 more: https://git.openjdk.org/jdk/compare/83c0e4516064846c956d9a760338e71be1593f6f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2023
@openjdk openjdk bot closed this Oct 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@bplb Pushed as commit 6c6beba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the CopyAndMove-8317128 branch October 6, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants