-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8317335: Build on windows fails after 8316645 #16000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review @lmesnik |
/integrate |
Going to push as commit 93f662f. |
@kimbarrett Pushed as commit 93f662f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this trivial change that fixes a build failure with Visual
Studio in Oracle's CI. The failure is a constant truncation warning because
the constant initial value of a
char
member is 0xaa, which is out of rangefor a signed 8bit char. This change uses 0x7a as the initial value, which is
in the required range.
Note that the problem code successfully builds in GitHub Actions. I don't
know why we're seeing this problem in Oracle's CI but not GA; perhaps a
difference in compiler versions?
Testing:
mach5 tier1
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16000/head:pull/16000
$ git checkout pull/16000
Update a local copy of the PR:
$ git checkout pull/16000
$ git pull https://git.openjdk.org/jdk.git pull/16000/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16000
View PR using the GUI difftool:
$ git pr show -t 16000
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16000.diff
Webrev
Link to Webrev Comment