Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes #16002

Closed
wants to merge 3 commits into from

Conversation

bourgesl
Copy link
Contributor

@bourgesl bourgesl commented Oct 1, 2023

For stroked shapes (no Renderer use), the min-join-error check is disabled.
Added new jtreg test to verify join using pixel counts


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16002/head:pull/16002
$ git checkout pull/16002

Update a local copy of the PR:
$ git checkout pull/16002
$ git pull https://git.openjdk.org/jdk.git pull/16002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16002

View PR using the GUI difftool:
$ git pr show -t 16002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16002.diff

Webrev

Link to Webrev Comment

…g on small shapes by disabling the min-join-error check for stroked shapes
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2023

👋 Welcome back lbourges! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2023

@bourgesl The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 1, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2023

Webrevs

@bourgesl
Copy link
Contributor Author

@prrace could you review this simple fix for jdk22, thatcan be backported to 21 next ?

@prrace
Copy link
Contributor

prrace commented Oct 10, 2023

Let me submit a test task to verify.

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all passed.

@bourgesl
Copy link
Contributor Author

Thanks @prrace for approval.
@kevinrushforth could you review this Marlin2D patch too as I want to backport it to openjdk 21 asap ?

@bourgesl
Copy link
Contributor Author

@johanvos could you review this fix?

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing that github shows I approved this but I certainly intended to. So hitting approve now.
Oh, maybe its because you have a mismatch in the title.

@bourgesl bourgesl changed the title JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes JDK-8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@bourgesl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes

Reviewed-by: prr, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 282 new commits pushed to the master branch:

  • 4cf195f: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.
  • af2f4bf: 8318622: ProblemList gc/cslocker/TestCSLocker.java on linux-x64 in Xcomp mode
  • a1a62d9: 8306308: (ch) Writer created by Channels::newWriter may lose data
  • 77b2394: 8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed
  • d3ebb4a: 8317373: Add Telia Root CA v2
  • 66d90d5: 8318107: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
  • 4dfa379: 7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field
  • 158293d: 8316030: Update Libpng to 1.6.40
  • a045258: 8209595: MonitorVmStartTerminate.java timed out
  • 2121575: 8318421: AbstractPipeline.sourceStageSpliterator() chases pointers needlessly
  • ... and 272 more: https://git.openjdk.org/jdk/compare/bd918f49d29bcbc699e07b4ef8d23cfe1abd32df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@bourgesl
Copy link
Contributor Author

As only @prrace approved, is it enough for me to integrate this PR or I need another reviewer ?

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2023
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable and the test looks good. Ran it myself and it passes with the changes.

@DamonGuy
Copy link
Contributor

DamonGuy commented Oct 20, 2023

As only @prrace approved, is it enough for me to integrate this PR or I need another reviewer ?

@bourgesl I have additionally approved it to make that decision easier. Typically, two Reviewers is recommended unless it's a really trivial change.

@bourgesl
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2023

Going to push as commit a876beb.
Since your change was applied there have been 282 commits pushed to the master branch:

  • 4cf195f: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.
  • af2f4bf: 8318622: ProblemList gc/cslocker/TestCSLocker.java on linux-x64 in Xcomp mode
  • a1a62d9: 8306308: (ch) Writer created by Channels::newWriter may lose data
  • 77b2394: 8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed
  • d3ebb4a: 8317373: Add Telia Root CA v2
  • 66d90d5: 8318107: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
  • 4dfa379: 7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field
  • 158293d: 8316030: Update Libpng to 1.6.40
  • a045258: 8209595: MonitorVmStartTerminate.java timed out
  • 2121575: 8318421: AbstractPipeline.sourceStageSpliterator() chases pointers needlessly
  • ... and 272 more: https://git.openjdk.org/jdk/compare/bd918f49d29bcbc699e07b4ef8d23cfe1abd32df...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2023
@openjdk openjdk bot closed this Oct 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2023
@openjdk
Copy link

openjdk bot commented Oct 21, 2023

@bourgesl Pushed as commit a876beb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants