-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317039 Enable specifying the JDK used to run jtreg #16010
Conversation
👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into |
@LudwikJaniuk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
I've addressed the comments left by @erikj79 so far. |
@LudwikJaniuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@LudwikJaniuk |
/sponsor |
Going to push as commit a250ae4.
Your commit was automatically rebased without conflicts. |
@dholmes-ora @LudwikJaniuk Pushed as commit a250ae4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This pull request introduces changes in the build makefiles necessary to enable the user to specify a jdk to use when launching jtreg. It introduces a new configure flag,
--with-jtreg-jdk
, which takes a JDK path similar to the already existing--with-boot-jdk
.Before this pull request, boot-jdk was always used to launch jtreg. This pull request decouples the two, but still defaults to boot-jdk if no value is specified.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16010/head:pull/16010
$ git checkout pull/16010
Update a local copy of the PR:
$ git checkout pull/16010
$ git pull https://git.openjdk.org/jdk.git pull/16010/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16010
View PR using the GUI difftool:
$ git pr show -t 16010
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16010.diff
Webrev
Link to Webrev Comment