Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException. #16013

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Oct 2, 2023

A simple clarification of the conditions for throwing an IAE.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8317270 to be approved

Issues

  • JDK-8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException. (Enhancement - P3)
  • JDK-8317270: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException. (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16013/head:pull/16013
$ git checkout pull/16013

Update a local copy of the PR:
$ git checkout pull/16013
$ git pull https://git.openjdk.org/jdk.git pull/16013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16013

View PR using the GUI difftool:
$ git pr show -t 16013

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16013.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2023
@openjdk
Copy link

openjdk bot commented Oct 2, 2023

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Oct 2, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException.

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • cfabcbf: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • b859da9: 8316696: Remove the testing base classes: IntlTest and CollatorTest
  • b438cff: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state
  • ae796a4: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi
  • 89987db: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code
  • 0e501f6: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads"
  • c47a0ce: 8317235: Remove Access API use in nmethod class
  • 353d139: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 3bcfac1: 8317246: Cleanup java.net.URLEncoder and URLDecoder use of file.encoding property
  • b6a97c0: 8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880
  • ... and 9 more: https://git.openjdk.org/jdk/compare/a564d436c722f14041231158f21c4ad3a2f6a3a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2023
@naotoj
Copy link
Member Author

naotoj commented Oct 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

Going to push as commit 1809b8c.
Since your change was applied there have been 19 commits pushed to the master branch:

  • cfabcbf: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • b859da9: 8316696: Remove the testing base classes: IntlTest and CollatorTest
  • b438cff: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state
  • ae796a4: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi
  • 89987db: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code
  • 0e501f6: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads"
  • c47a0ce: 8317235: Remove Access API use in nmethod class
  • 353d139: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 3bcfac1: 8317246: Cleanup java.net.URLEncoder and URLDecoder use of file.encoding property
  • b6a97c0: 8316880: AArch64: "stop: Header is not fast-locked" with -XX:-UseLSE since JDK-8315880
  • ... and 9 more: https://git.openjdk.org/jdk/compare/a564d436c722f14041231158f21c4ad3a2f6a3a5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2023
@openjdk openjdk bot closed this Oct 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@naotoj Pushed as commit 1809b8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants