Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch #16023

Closed
wants to merge 1 commit into from

Conversation

gergo-
Copy link

@gergo- gergo- commented Oct 3, 2023

This test requires certain methods to be compiled, but without -Xbatch the compiler races against the test code, which can lead to intermittent failures.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16023/head:pull/16023
$ git checkout pull/16023

Update a local copy of the PR:
$ git checkout pull/16023
$ git pull https://git.openjdk.org/jdk.git pull/16023/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16023

View PR using the GUI difftool:
$ git pr show -t 16023

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16023.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

👋 Welcome back gbarany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@gergo- The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 3, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

@gergo- This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@gergo-
Copy link
Author

gergo- commented Oct 31, 2023

@TobiHartmann might I ask you for a review of this trivial PR, or to suggest an appropriate reviewer from the HotSpot team?

@jaikiran
Copy link
Member

jaikiran commented Nov 2, 2023

Adding hotspot label because from the looks of this change, it appears to require someone from that area to review this.

/label add hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@jaikiran
The hotspot label was successfully added.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@gergo- This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch

Reviewed-by: dnsimon, never, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 501 new commits pushed to the master branch:

  • 806529a: 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle
  • e9eb8b9: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • 8eb6f61: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 8274713: 8314891: Additional Zip64 extra header validation
  • 0dcd730: 8318594: NMT: VM.native_memory crashes on assert if functionality isn't supported by OS
  • 45e68ae: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
  • 4a0ad46: 8317937: @sealedGraph: Links to inner classes fails in links
  • 134c382: 8319560: Reformat method parameters in the FFM API
  • ef8c840: 8319607: FFM: Review the language in the FFM documentation
  • bf9a93d: 8319204: G1: Change G1CMTask::_termination_time_ms to wallclock time
  • ... and 491 more: https://git.openjdk.org/jdk/compare/bd918f49d29bcbc699e07b4ef8d23cfe1abd32df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc, @tkrodriguez, @PaulSandoz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 6, 2023
@gergo-
Copy link
Author

gergo- commented Nov 6, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@gergo-
Your change (at version 4cabbfd) is now ready to be sponsored by a Committer.

@dougxc
Copy link
Member

dougxc commented Nov 7, 2023

@PaulSandoz do you see any problem with this change? Adding -Xbatch does not significantly increase the test run time.

@PaulSandoz
Copy link
Member

@PaulSandoz do you see any problem with this change? Adding -Xbatch does not significantly increase the test run time.

Seems ok to me.

@dougxc
Copy link
Member

dougxc commented Nov 7, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit a290256.
Since your change was applied there have been 502 commits pushed to the master branch:

  • b1625af: 8305814: Update Xalan Java to 2.7.3
  • 806529a: 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle
  • e9eb8b9: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • 8eb6f61: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 8274713: 8314891: Additional Zip64 extra header validation
  • 0dcd730: 8318594: NMT: VM.native_memory crashes on assert if functionality isn't supported by OS
  • 45e68ae: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
  • 4a0ad46: 8317937: @sealedGraph: Links to inner classes fails in links
  • 134c382: 8319560: Reformat method parameters in the FFM API
  • ef8c840: 8319607: FFM: Review the language in the FFM documentation
  • ... and 492 more: https://git.openjdk.org/jdk/compare/bd918f49d29bcbc699e07b4ef8d23cfe1abd32df...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@dougxc @gergo- Pushed as commit a290256.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
5 participants