Skip to content

8317422: [JVMCI] concurrency issue in MethodData creation #16026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8317422: [JVMCI] concurrency issue in MethodData creation #16026

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1656050
use Method::build_profiling_method_data in JVMCI
dougxc Oct 3, 2023
fda052d
replace set_method_data with clear_method_data
dougxc Oct 4, 2023
618ed18
made clear_method_data private and moved its definition inline
dougxc Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/hotspot/share/oops/method.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,6 @@ class Method : public Metadata {
return _method_data;
}

void clear_method_data();

MethodCounters* method_counters() const {
return _method_counters;
}
Expand Down Expand Up @@ -361,6 +359,10 @@ class Method : public Metadata {
// Either called with CompiledMethod_lock held or from constructor.
void clear_code();

void clear_method_data() {
_method_data = nullptr;
}

public:
static void set_code(const methodHandle& mh, CompiledMethod* code);
void set_adapter_entry(AdapterHandlerEntry* adapter) {
Expand Down
4 changes: 0 additions & 4 deletions src/hotspot/share/oops/method.inline.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ inline address Method::from_interpreted_entry() const {
return Atomic::load_acquire(&_from_interpreted_entry);
}

inline void Method::clear_method_data() {
_method_data = nullptr;
}

inline CompiledMethod* Method::code() const {
assert( check_code(), "" );
return Atomic::load_acquire(&_code);
Expand Down