Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316608: Enable parallelism in vmTestbase/gc/vector tests #16028

Closed

Conversation

roy-soumadipta
Copy link
Contributor

@roy-soumadipta roy-soumadipta commented Oct 3, 2023

The commit includes changes to unblock parallelism for more hotspot:tier4 tests. in vmTestbase/gc/vector tests.

Below are the before and after run comparisons:

# Fastdebug
before: 3480.71s user 83.97s system 830% cpu 7:09.41 total
after: 2214.52s user 63.19s system 2374% cpu 1:35.94 total

# Release
before: 1369.61s user 147.03s system 371% cpu 6:48.63 total
after: 1130.28s user 110.97s system 2478% cpu 50.089 total

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8316608: Enable parallelism in vmTestbase/gc/vector tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16028/head:pull/16028
$ git checkout pull/16028

Update a local copy of the PR:
$ git checkout pull/16028
$ git pull https://git.openjdk.org/jdk.git pull/16028/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16028

View PR using the GUI difftool:
$ git pr show -t 16028

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16028.diff

Webrev

Link to Webrev Comment

The commit includes changes to unblock parallelism for more `hotspot:tier4` tests. in `vmTestbase/gc/vector` tests.

Below are the before and after run comparisons:
* before_fastdebug: **3480.71s user 83.97s system 830% cpu 7:09.41 total**
* before_release: **1369.61s user 147.03s system 371% cpu 6:48.63 total**
* after_fastdebug: **2214.52s user 63.19s system 2374% cpu 1:35.94 total**
* after_release: **1130.28s user 110.97s system 2478% cpu 50.089 total**
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@roy-soumadipta The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 3, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2023

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, but @tschatzl and @lmesnik need to be looped in for visibility.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@roy-soumadipta This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316608: Enable parallelism in vmTestbase/gc/vector tests

Reviewed-by: shade, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 3ff5a78: 8317693: Unused parameter to Tokens.Token.comment method
  • 508fa71: 8317736: Stream::handleReset locks twice
  • 1f06325: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values
  • a07a4a3: 8317422: [JVMCI] concurrency issue in MethodData creation
  • 7ff1938: 8310727: C2: *_of() methods in PhaseIterGVN should use uint for the node index
  • a57ae7e: 8317594: G1: Refactor find_empty_from_idx_reverse
  • 6ddbfaa: 8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java
  • 0cf1a55: 8317440: Lock rank checking fails when code root set is modified with the Servicelock held after JDK-8315503
  • bcc986b: 8317601: Windows build on WSL broken after JDK-8317340
  • 460ebcd: 8314978: Multiple server call from connection failing with expect100 in getOutputStream
  • ... and 44 more: https://git.openjdk.org/jdk/compare/3bcfac18c39d83bf876787e7ce422831bab0db2f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 4, 2023
Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing didn't show any issues

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2023
@roy-soumadipta
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@roy-soumadipta
Your change (at version e0b0943) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/integrate

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@phohensee Only the author (@roy-soumadipta) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

Going to push as commit f61499c.
Since your change was applied there have been 54 commits pushed to the master branch:

  • 3ff5a78: 8317693: Unused parameter to Tokens.Token.comment method
  • 508fa71: 8317736: Stream::handleReset locks twice
  • 1f06325: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values
  • a07a4a3: 8317422: [JVMCI] concurrency issue in MethodData creation
  • 7ff1938: 8310727: C2: *_of() methods in PhaseIterGVN should use uint for the node index
  • a57ae7e: 8317594: G1: Refactor find_empty_from_idx_reverse
  • 6ddbfaa: 8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java
  • 0cf1a55: 8317440: Lock rank checking fails when code root set is modified with the Servicelock held after JDK-8315503
  • bcc986b: 8317601: Windows build on WSL broken after JDK-8317340
  • 460ebcd: 8314978: Multiple server call from connection failing with expect100 in getOutputStream
  • ... and 44 more: https://git.openjdk.org/jdk/compare/3bcfac18c39d83bf876787e7ce422831bab0db2f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 9, 2023
@openjdk openjdk bot closed this Oct 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@phohensee @roy-soumadipta Pushed as commit f61499c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
4 participants