Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp #16031

Closed
wants to merge 3 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 3, 2023

Trivial fixes to ProblemList noisy tests in the JDK22 CI;

JDK-8317446 ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
JDK-8317448 ProblemList compiler/interpreter/TestVerifyStackAfterDeopt.java on macosx-aarch64 in Xcomp
JDK-8317449 ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java on several platforms


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp (Sub-task - P4)
  • JDK-8317448: ProblemList compiler/interpreter/TestVerifyStackAfterDeopt.java on macosx-aarch64 in Xcomp (Sub-task - P2)
  • JDK-8317449: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java on several platforms (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16031/head:pull/16031
$ git checkout pull/16031

Update a local copy of the PR:
$ git checkout pull/16031
$ git pull https://git.openjdk.org/jdk.git pull/16031/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16031

View PR using the GUI difftool:
$ git pr show -t 16031

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16031.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-gc
/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk
The hotspot-compiler label was successfully added.

…ded/GetStackTraceNotSuspendedStressTest.java on several platforms
@dcubed-ojdk
Copy link
Member Author

/issue JDK-8317446
/issue JDK-8317448
/issue JDK-8317449

/label add serviceability

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8317448: ProblemList compiler/interpreter/TestVerifyStackAfterDeopt.java on macosx-aarch64 in Xcomp.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review October 3, 2023 18:21
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk
Adding additional issue to issue list: 8317449: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java on several platforms.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 3, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp
8317448: ProblemList compiler/interpreter/TestVerifyStackAfterDeopt.java on macosx-aarch64 in Xcomp
8317449: ProblemList serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java on several platforms

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cfabcbf: 8317121: vector_masked_load instruction is moved too early after JDK-8286941

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2023
@dcubed-ojdk
Copy link
Member Author

@TobiHartmann - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

Going to push as commit 8ff10a0.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 1809b8c: 8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException.
  • cfabcbf: 8317121: vector_masked_load instruction is moved too early after JDK-8286941

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2023
@openjdk openjdk bot closed this Oct 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@dcubed-ojdk Pushed as commit 8ff10a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@theRealAph
Copy link
Contributor

What is this all about? I can't see any link to a root cause.

@TobiHartmann
Copy link
Member

This change is simply problem listing multiple tests. As described in the OpenJDK Developers’ Guide, the problem listing issues are sub-tasks of the actual (still open) issues and are linked by Skara in the "Issues" section of this PR. The corresponding JBS issues are also listed in the problem list entries themselves.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8317446 branch October 7, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants