-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317452: [JVMCI] Export symbols used by lightweight locking to JVMCI compilers. #16032
Conversation
👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into |
@mur47x111 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@mur47x111 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Webrevs
|
@@ -127,9 +127,6 @@ class fileStream; | |||
product(bool, JVMCICountersExcludeCompiler, true, EXPERIMENTAL, \ | |||
"Exclude JVMCI compiler threads from benchmark counters") \ | |||
\ | |||
develop(bool, JVMCIUseFastLocking, true, \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should just delete this option - JVMCI is clearly marked as experimental.
What you have in this PR is not proper deprecation. What if someone specifies -XX:-JVMCIUseFastLocking
? They will get no warning or VM exit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. I have deleted the option.
@mur47x111 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@mur47x111 |
/integrate |
@dougxc Only the author (@mur47x111) is allowed to issue the |
/sponsor |
Going to push as commit 9718f49.
Your commit was automatically rebased without conflicts. |
@dougxc @mur47x111 Pushed as commit 9718f49. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Export JavaThread::_lock_stack, LockStack::_top, LockStack::_end_offset, and ObjectMonitor::ANONYMOUS_OWNER to JVMCI compilers. Delete JVMCIUseFastLocking option
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16032/head:pull/16032
$ git checkout pull/16032
Update a local copy of the PR:
$ git checkout pull/16032
$ git pull https://git.openjdk.org/jdk.git pull/16032/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16032
View PR using the GUI difftool:
$ git pr show -t 16032
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16032.diff
Webrev
Link to Webrev Comment