Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java #16037

Closed
wants to merge 1 commit into from

Conversation

varada1110
Copy link
Contributor

@varada1110 varada1110 commented Oct 4, 2023

A trivial change to ProblemList runtime/jni/terminatedThread/TestTerminatedThread.java on aix-ppc64

JBS issue : JDK-8317136


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16037/head:pull/16037
$ git checkout pull/16037

Update a local copy of the PR:
$ git checkout pull/16037
$ git pull https://git.openjdk.org/jdk.git pull/16037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16037

View PR using the GUI difftool:
$ git pr show -t 16037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16037.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2023

👋 Welcome back varada1110! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@varada1110 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@varada1110
Copy link
Contributor Author

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@varada1110
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 4, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

Thanks

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@varada1110 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java

Reviewed-by: dholmes, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 0cf1a55: 8317440: Lock rank checking fails when code root set is modified with the Servicelock held after JDK-8315503
  • bcc986b: 8317601: Windows build on WSL broken after JDK-8317340
  • 460ebcd: 8314978: Multiple server call from connection failing with expect100 in getOutputStream
  • dc4bc4f: 8306819: Consider disabling the compiler's default active annotation processing
  • a4e9168: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays)
  • 6c6beba: 8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException
  • b62e774: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long
  • a64794b: 8317560: Change to Xcode 14.3.1 for building on macOS at Oracle
  • b3cc0c8: 8317318: Serial: Change GenCollectedHeap to SerialHeap in whitebox
  • 691db5d: 8317592: Serial: Remove Space::toContiguousSpace
  • ... and 22 more: https://git.openjdk.org/jdk/compare/d4c904d81970bbe5b0afe1029eae705366779839...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @offamitkumar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 5, 2023
@varada1110
Copy link
Contributor Author

/integrate
Thank you @dholmes-ora

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@varada1110
Your change (at version 57cbeab) is now ready to be sponsored by a Committer.

Copy link
Member

@offamitkumar offamitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable.
@varada1110 it will be better if you link current issue to JDK-8219652, over jbs.

@offamitkumar
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

Going to push as commit 6ddbfaa.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 0cf1a55: 8317440: Lock rank checking fails when code root set is modified with the Servicelock held after JDK-8315503
  • bcc986b: 8317601: Windows build on WSL broken after JDK-8317340
  • 460ebcd: 8314978: Multiple server call from connection failing with expect100 in getOutputStream
  • dc4bc4f: 8306819: Consider disabling the compiler's default active annotation processing
  • a4e9168: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays)
  • 6c6beba: 8317128: java/nio/file/Files/CopyAndMove.java failed with AccessDeniedException
  • b62e774: 8317515: Unify the code of the parse*() families of methods in j.l.Integer and j.l.Long
  • a64794b: 8317560: Change to Xcode 14.3.1 for building on macOS at Oracle
  • b3cc0c8: 8317318: Serial: Change GenCollectedHeap to SerialHeap in whitebox
  • 691db5d: 8317592: Serial: Remove Space::toContiguousSpace
  • ... and 22 more: https://git.openjdk.org/jdk/compare/d4c904d81970bbe5b0afe1029eae705366779839...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 9, 2023
@openjdk openjdk bot closed this Oct 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@offamitkumar @varada1110 Pushed as commit 6ddbfaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger
Copy link
Contributor

RealCLanger commented Oct 9, 2023

@varada1110 I think it is wrong to exclude this test with reference to an already fixed bug. Also, the failure we are seeing in SAP's testing of AIX is a timeout - pretty much different to the synopsis described in JDK-8219652. Is this the type of failure you are seeing for TestTerminatedThread, too?

@RealCLanger
Copy link
Contributor

RealCLanger commented Oct 10, 2023

I have created JDK-8317789 for the error we're currently facing on AIX with runtime/jni/terminatedThread/TestTerminatedThread.java and opened PR #16114 to update the test exclusion. Please check whether that's the same type of error that you're seeing.

@varada1110
Copy link
Contributor Author

Thank you @RealCLanger. And yes I see the same error on AIX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants