-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8317502 Add asserts to check for non-null in ciInstance::java_lang_Class_klass #16038
Conversation
…g_Class_klass and ciTypeArrayKlass::make
👋 Welcome back dfenacci! A progress list of the required criteria for merging this PR into |
…ady present in Universe::typeArrayKlassObj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
@dafedafe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 122 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
Thank you very much for the reviews @vnkozlov @TobiHartmann. |
/integrate |
Going to push as commit f0d66d1.
Your commit was automatically rebased without conflicts. |
ciInstance::java_lang_Class_klass
andciTypeArrayKlass::make_impl
could potentially return anull
pointer (solely based on the code). A static code analyzer found out that in other places in the code this could potentially lead to a null pointer dereferencing. However we know that this will never happen:java_lang_Class::as_Klass(get_oop())
cannot be null and neither canUniverse::typeArrayKlassObj(t)
(there is already an explicit assert intypeArrayKlassObj
).So, this change adds an assert in
ciInstance::java_lang_Class_klass
ensuring thatjava_lang_Class::as_Klass(get_oop())
don't returnnullptr
(no assert inciTypeArrayKlass::make_impl
asUniverse::typeArrayKlassObj(t)
already includes one for_typeArrayKlassObjs[t] != nullptr
).Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16038/head:pull/16038
$ git checkout pull/16038
Update a local copy of the PR:
$ git checkout pull/16038
$ git pull https://git.openjdk.org/jdk.git pull/16038/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16038
View PR using the GUI difftool:
$ git pr show -t 16038
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16038.diff
Webrev
Link to Webrev Comment