Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong #16041

Closed

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Oct 4, 2023

The AbstractThrowingSubscribers.java test class makes the assumption that the HttpClient will cancel a request if the body CompletableFuture returned by a BodySubscriber::getBody is completed exceptionally. This assumption is wrong. Indeed, it should be the responsibility of the custom subscriber to cancel its subscription, or not, in such a case, as whether to cancel or not depends on the semantic the subscriber assigns to such a body.

The issue can be observed by modifying the test to send a longer response split in several chunks: with such a configuration, and using streaming body subscribers, such as ofInputStream, the test will fail waiting for the HttpClient to be garbaged collected, as the response data will not get pulled and the underlying exchange will never terminate. Though changing the HttpClient code to forcefully cancel the subscription (or the exchange) in such a case would "work", it does not seem desirable: it would introduce a change of behavior that might cause existing applications to fail, and there may be cases where a custom subscriber may legitimately want to complete its body CF exceptionally while still continuing to parse the body bytes. Whether to choose to cancel the subscription or not should solely depend on the logic of the custom subscriber.

The test logic is now modified to reflect this. Commenting the line that cancels the subscription in ThrowingBodySubscriber::getBody would now make the test fail. The test was previously passing "by chance" because the whole response was contained in a single DataFrame (or ByteBuffer for HTTP/1.1).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16041/head:pull/16041
$ git checkout pull/16041

Update a local copy of the PR:
$ git checkout pull/16041
$ git pull https://git.openjdk.org/jdk.git pull/16041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16041

View PR using the GUI difftool:
$ git pr show -t 16041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16041.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2023

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8317522 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong Oct 4, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 4, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2023

Webrevs

Copy link
Member

@djelinski djelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong

Reviewed-by: djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • c6c69b5: 8314654: Metaspace: move locking out of MetaspaceArena
  • 3105538: 8316146: Open some swing tests 4
  • 36314a9: 8267509: Improve IllegalAccessException message to include the cause of the exception
  • ddacf92: 8305765: CompressedClassPointers.java is unreliable due to ASLR
  • 4195246: 8317354: Serial: Move DirtyCardToOopClosure to gc/serial folder
  • 0a3a925: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • b0d6c84: 8316396: Endless loop in C2 compilation triggered by AddNode::IdealIL
  • a8549b6: 8280120: [IR Framework] Add attribute to @ir to enable/disable IR matching based on the architecture

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 5, 2023
@dfuch
Copy link
Member Author

dfuch commented Oct 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

Going to push as commit 4c5b66d.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 42be238: 8316523: Relativize esp in interpreter frames (PowerPC only)
  • a250ae4: 8317039: Enable specifying the JDK used to run jtreg
  • 1ed9c76: 8309204: Obsolete DoReserveCopyInSuperWord
  • 3630af2: 8316594: C2 SuperWord: wrong result with hand unrolled loops
  • c6c69b5: 8314654: Metaspace: move locking out of MetaspaceArena
  • 3105538: 8316146: Open some swing tests 4
  • 36314a9: 8267509: Improve IllegalAccessException message to include the cause of the exception
  • ddacf92: 8305765: CompressedClassPointers.java is unreliable due to ASLR
  • 4195246: 8317354: Serial: Move DirtyCardToOopClosure to gc/serial folder
  • 0a3a925: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • ... and 2 more: https://git.openjdk.org/jdk/compare/9718f490fb76f6712ac8f9c7f5248ca10bf83e6f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2023
@openjdk openjdk bot closed this Oct 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@dfuch Pushed as commit 4c5b66d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
2 participants