Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification #16052

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 5, 2023

This is another (hopefully better) attempt at fixing the issue described by JDK-8315932. The previous attempt tried to tune the Metaspace parameters, hoping for a more frequent GCs. This patch just does the GCs explicitly in the tests.

There is a tradeoff between spending more on frequent GCs and having fewer dependencies to verify. But it is a win on all thresholds. I have selected the best threshold with a light bisection.

# Testing with CONF=linux-x86_64-server-fastdebug make test TEST=runtime/InvocationTests/  

# Current run time
4312.23s user 93.50s system 467% cpu 15:42.02 total

Original fix:
2875.61s user 116.28s system 677% cpu 7:21.57 total

# GC every 8192 classes
3666.35s user 98.30s system 489% cpu 12:49.13 total

# GC every 4096 classes
3083.87s user 104.52s system 586% cpu 9:04.06 total

# GC every 3000 classes <---- this PR
3066.15s user 110.85s system 613% cpu 8:37.96 total

# GC every 2500 classes
3079.33s user 114.35s system 582% cpu 9:07.85 total

# GC every 2048 classes
3171.62s user 116.97s system 492% cpu 11:07.38 total

# GC every 1024 classes
3112.66s user 114.94s system 506% cpu 10:37.35 total

# GC every 512 classes
3180.21s user 122.11s system 508% cpu 10:48.85 total

# GC every 128 classes
3628.81s user 90.54s system 481% cpu 12:52.88 total

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16052/head:pull/16052
$ git checkout pull/16052

Update a local copy of the PR:
$ git checkout pull/16052
$ git pull https://git.openjdk.org/jdk.git pull/16052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16052

View PR using the GUI difftool:
$ git pr show -t 16052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16052.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 5, 2023
@shipilev shipilev marked this pull request as ready for review October 6, 2023 14:32
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2023

Webrevs

@shipilev
Copy link
Member Author

Anyone? Particularly @tstuefe, @iwanowww?

Copy link

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

(Testing - hs-tier1-hs-tier4 - passed.)

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification

Reviewed-by: vlivanov, stuefe, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 199 new commits pushed to the master branch:

  • 56aa1e8: 8317683: Add JIT memory statistics
  • f7d6d7a: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e942f36: 8317535: Shenandoah: Remove unused code
  • 7cb2e6d: 8317514: Ensure MemorySegment is initialized before touching NativeMemorySegmentImpl
  • 9622de2: 8317372: Refactor some NumberFormat tests to use JUnit
  • 72c4dcb: 8317970: Bump target macosx-x64 version to 11.00.00
  • 32a60cf: 8317824: Beef up javadoc for base offset in var handles derived from layouts (mainline)
  • b12c471: 8317837: Leftover FFM implementation-only changes
  • 605c976: 8318039: GHA: Bump macOS and Xcode versions
  • 6273ab9: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
  • ... and 189 more: https://git.openjdk.org/jdk/compare/5350fd617390aaaedf8dd8821418c796cb1c38b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2023
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shipilev
Copy link
Member Author

Thanks all!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

Going to push as commit 1e930db.
Since your change was applied there have been 204 commits pushed to the master branch:

  • 0275efa: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 77d40ce: 8318085: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-aarch64
  • 4ea1b99: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"
  • 01ea1ef: 8305971: NPE in JavacProcessingEnvironment for missing enum constructor body
  • 1d54e73: 8318072: DowncallLinker does not acquire/release segments in interpreter
  • 56aa1e8: 8317683: Add JIT memory statistics
  • f7d6d7a: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e942f36: 8317535: Shenandoah: Remove unused code
  • 7cb2e6d: 8317514: Ensure MemorySegment is initialized before touching NativeMemorySegmentImpl
  • 9622de2: 8317372: Refactor some NumberFormat tests to use JUnit
  • ... and 194 more: https://git.openjdk.org/jdk/compare/5350fd617390aaaedf8dd8821418c796cb1c38b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2023
@openjdk openjdk bot closed this Oct 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@shipilev Pushed as commit 1e930db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8316585-dep-verify branch November 28, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants