8312475: org.jline.util.PumpReader signed byte problem

[msobiers]

Added casting to & 0xFF to the InputStream read method return value.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8312475: org.jline.util.PumpReader signed byte problem (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16053/head:pull/16053
$ git checkout pull/16053

Update a local copy of the PR:
$ git checkout pull/16053
$ git pull https://git.openjdk.org/jdk.git pull/16053/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16053

View PR using the GUI difftool:
$ git pr show -t 16053

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16053.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back msobiers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@msobiers The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b5922017)

[msobiers]

/covered

[bridgekeeper]

You are already a known contributor!

[shipilev]

@lahodaj, what do you think?

[shipilev]

@lahodaj, what do you think?

Ping @lahodaj again :)

[shipilev]

I am providing a second review anyway.

/reviewers 2

[openjdk]

@msobiers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312475: org.jline.util.PumpReader signed byte problem

Reviewed-by: shade, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 474 new commits pushed to the master branch:

• 7c0a828: 8318649: G1: Remove unimplemented HeapRegionRemSet::add_code_root_locked
• ff5c5b6: 8318643: +UseTransparentHugePages must enable +UseLargePages
• fc29a2e: 8318082: ConcurrentModificationException from IndexWriter
• 729f4c5: 8318507: G1: Improve remset clearing for humongous candidates
• 4eab39d: 8318585: Rename CodeCache::UnloadingScope to UnlinkingScope
• ffadd63: 8317868: Add @sealedGraph to MethodHandleDesc and descendants
• ecd25e7: 8318484: Initial version of cdsConfig.hpp
• a876beb: 8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes
• 4cf195f: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.
• af2f4bf: 8318622: ProblemList gc/cslocker/TestCSLocker.java on linux-x64 in Xcomp mode
• ... and 464 more: https://git.openjdk.org/jdk/compare/3828dc913a3ea28d622b69bd07f26949128eb5f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[lahodaj]

Makes sense - has this been reported upstream yet? Alternatively, Byte.toUnsignedInt could be used.

In any case, I suspect this class is not used in the JDK, so I don't expect any impact from this.

[msobiers]

/integrate

[openjdk]

@msobiers
Your change (at version b592201) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit bea2d48.
Since your change was applied there have been 479 commits pushed to the master branch:

• 9f767aa: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
• bd22d23: 8318027: Support alternative name to jdk.internal.vm.compiler
• c2efd77: 8295795: hsdis does not build with binutils 2.39+
• 99de9bb: 8317807: JAVA_FLAGS removed from jtreg running in JDK-8317039
• 704c6ea: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java
• 7c0a828: 8318649: G1: Remove unimplemented HeapRegionRemSet::add_code_root_locked
• ff5c5b6: 8318643: +UseTransparentHugePages must enable +UseLargePages
• fc29a2e: 8318082: ConcurrentModificationException from IndexWriter
• 729f4c5: 8318507: G1: Improve remset clearing for humongous candidates
• 4eab39d: 8318585: Rename CodeCache::UnloadingScope to UnlinkingScope
• ... and 469 more: https://git.openjdk.org/jdk/compare/3828dc913a3ea28d622b69bd07f26949128eb5f7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @msobiers Pushed as commit bea2d48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.