8317592: Serial: Remove Space::toContiguousSpace

[albertnetymk]

Simple removing unnecessary abstraction after using more precise type.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317592: Serial: Remove Space::toContiguousSpace (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16054/head:pull/16054
$ git checkout pull/16054

Update a local copy of the PR:
$ git checkout pull/16054
$ git pull https://git.openjdk.org/jdk.git pull/16054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16054

View PR using the GUI difftool:
$ git pr show -t 16054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16054.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5245bd70)

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317592: Serial: Remove Space::toContiguousSpace

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• ec9ba5d: 8317660: [BACKOUT] 8269393: store/load order not preserved when handling memory pool due to weakly ordered memory architecture of aarch64
• 7162624: 8269393: store/load order not preserved when handling memory pool due to weakly ordered memory architecture of aarch64
• f0d66d1: 8317502: Add asserts to check for non-null in ciInstance::java_lang_Class_klass
• 991ce84: 4964430: (spec) missing IllegalStateException exception requirement for javax.crypto.Cipher.doFinal
• 8a30c2a: 8317443: StackOverflowError on calling ListFormat::getInstance() for Norwegian locales
• a1c9587: 8313348: Fix typo in JFormattedTextField: 'it self'
• a8eacb3: 8317240: Promptly free OopMapEntry after fail to insert the entry to OopMapCache
• 4c5b66d: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong
• 42be238: 8316523: Relativize esp in interpreter frames (PowerPC only)
• a250ae4: 8317039: Enable specifying the JDK used to run jtreg
• ... and 6 more: https://git.openjdk.org/jdk/compare/4195246fba721934f2b2c0525b1d5b2fe4b08122...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 691db5d.
Since your change was applied there have been 16 commits pushed to the master branch:

• ec9ba5d: 8317660: [BACKOUT] 8269393: store/load order not preserved when handling memory pool due to weakly ordered memory architecture of aarch64
• 7162624: 8269393: store/load order not preserved when handling memory pool due to weakly ordered memory architecture of aarch64
• f0d66d1: 8317502: Add asserts to check for non-null in ciInstance::java_lang_Class_klass
• 991ce84: 4964430: (spec) missing IllegalStateException exception requirement for javax.crypto.Cipher.doFinal
• 8a30c2a: 8317443: StackOverflowError on calling ListFormat::getInstance() for Norwegian locales
• a1c9587: 8313348: Fix typo in JFormattedTextField: 'it self'
• a8eacb3: 8317240: Promptly free OopMapEntry after fail to insert the entry to OopMapCache
• 4c5b66d: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong
• 42be238: 8316523: Relativize esp in interpreter frames (PowerPC only)
• a250ae4: 8317039: Enable specifying the JDK used to run jtreg
• ... and 6 more: https://git.openjdk.org/jdk/compare/4195246fba721934f2b2c0525b1d5b2fe4b08122...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 691db5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.