-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8317631: Refactor ChoiceFormat tests to use JUnit #16065
Conversation
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
@justin-curtis-lu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
// Compare the expected results with the new formatted results | ||
assertEquals(after.toString(), original, | ||
"Mutating array returned from getter changed internals of ChoiceFormat"); | ||
|
||
// Modify the array passed to setFormats() -> dayOfWeekNames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the err
variable, and not throw an exception (and end the test) here. Otherwise, the test after this will not run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I should have actually split this larger test into two separate tests (one for the getter / one for the setter), then there would be no need for err
.
I have updated the PR with the change I mentioned. Thank you for reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point dividing the test for granularity. Looks good
double[] newLimits = form.getLimits(); | ||
String[] newFormats = (String[])form.getFormats(); | ||
/* | ||
* Ensure that mutating he arrays returned by getChoices and getLimits does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: typo "he"
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 5e8d893.
Your commit was automatically rebased without conflicts. |
@justin-curtis-lu Pushed as commit 5e8d893. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which refactors the ChoiceFormat tests to use JUnit.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16065/head:pull/16065
$ git checkout pull/16065
Update a local copy of the PR:
$ git checkout pull/16065
$ git pull https://git.openjdk.org/jdk.git pull/16065/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16065
View PR using the GUI difftool:
$ git pr show -t 16065
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16065.diff
Webrev
Link to Webrev Comment