-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8257725: No throws of SSLHandshakeException #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into |
@XueleiFan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@@ -1,5 +1,5 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update should be in another branch. I'm not very sure why it comes into this branch. I will make sure to get rid of it before integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
@XueleiFan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@XueleiFan Pushed as commit d76039d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In the StatusResponseManager.get() method spec, the SSLHandshakeException is declared as throws exception. However, no such checked-exception would be thrown in the method implementation.
/**
...
*/
Map<X509Certificate, byte[]> get(CertStatusRequestType type,
CertStatusRequest request, X509Certificate[] chain, long delay,
TimeUnit unit) {
As the exception is a checked-exception, and is not declared in the method, it is safe to remove the throws spec.
Cleanup only, no new regression test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8257725
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1607/head:pull/1607
$ git checkout pull/1607