Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id #16073

Closed
wants to merge 4 commits into from

Conversation

Agnibho-8
Copy link
Contributor

@Agnibho-8 Agnibho-8 commented Oct 6, 2023

Please review this PR as a fix of JDK-8249832. I have added the bug with after @ignore annotation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16073/head:pull/16073
$ git checkout pull/16073

Update a local copy of the PR:
$ git checkout pull/16073
$ git pull https://git.openjdk.org/jdk.git pull/16073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16073

View PR using the GUI difftool:
$ git pr show -t 16073

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16073.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 6, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2023

Hi @Agnibho-8, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Agnibho-8" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@Agnibho-8 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 6, 2023
@Agnibho-8
Copy link
Contributor Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 6, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2023

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 11, 2023
@Agnibho-8 Agnibho-8 changed the title java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id Oct 12, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2023

Webrevs

@mahendrachhipa
Copy link
Member

mahendrachhipa commented Oct 12, 2023

Looks good to me. Please update the copyright year.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the Copyright year.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@mahendrachhipa
Copy link
Member

Looks Good to me.

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

⚠️ @Agnibho-8 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8249832
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@Agnibho-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id

Reviewed-by: msheppar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 198 new commits pushed to the master branch:

  • aed1e81: 8317285: Misspellings in hprof test lib
  • 741ae06: 8313613: Use JUnit in langtools/lib tests
  • 8c1bb2b: 8268916: Tests for AffirmTrust roots
  • 2d38495: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame
  • 0d09168: 8312527: (ch) Re-examine use of sun.nio.ch.Invoker.myGroupAndInvokeCount
  • 1a7fd5d: 8317687: (fs) FileStore.supportsFileAttributeView("posix") incorrectly returns 'true' for FAT32 volume on macOS
  • eb7d972: 8308659: Use CSS scroll-margin instead of flexbox layout in API documentation
  • 7028fb9: 8317975: [JVMCI] assert(pointee != nullptr) failed: invariant
  • 36993ae: 8316918: Optimize conversions duplicated across phi nodes
  • 668d4b0: 8318154: Improve stability of WheelModifier.java test
  • ... and 188 more: https://git.openjdk.org/jdk/compare/3481a485716a1949706a4dcb94181b07e88e804d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@msheppar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 16, 2023
@Agnibho-8
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@Agnibho-8
Your change (at version 8191bc5) is now ready to be sponsored by a Committer.

@mahendrachhipa
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit 34653c1.
Since your change was applied there have been 209 commits pushed to the master branch:

  • d8cd605: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
  • 8f79d88: 8318155: Remove unnecessary virtual specifier in Space
  • b2b8db6: 8318180: Memory model reference from foreign package-info is broken
  • 5bd1052: 8317317: G1: Make TestG1RemSetFlags use createTestJvm
  • c64bd3d: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 6ee6171: 8317347: Parallel: Make TestInitialTenuringThreshold use createTestJvm
  • 7ca0ae9: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • 5521560: 8310673: [JVMCI] batch compilation for libgraal should work the same way as for C2
  • e4329a8: 8317696: Fix compilation with clang-16
  • 504b0bd: 8318078: ADLC: pass ASSERT and PRODUCT flags
  • ... and 199 more: https://git.openjdk.org/jdk/compare/3481a485716a1949706a4dcb94181b07e88e804d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@mahendrachhipa @Agnibho-8 Pushed as commit 34653c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants