Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8209595: MonitorVmStartTerminate.java timed out #16077

Closed

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Oct 6, 2023

From studying test failures, it looks like the way the test identifies its related processes is failing.
It checks the mainArgs of a process by attaching, and looks like it occasionally misses getting a valid match. The hasMainArgs method ignores exceptions as it is expecting some exceptions: it is going to test unrelated java process which happen to start.

It should retry this main args check on failure, but not too many times to be a burden on other valid unrelated processes, and should also log the PIDs that have an issue so we can see if this is part of any future failure.

Other small logging changes so we can see more easily the progress through the test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8209595: MonitorVmStartTerminate.java timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16077/head:pull/16077
$ git checkout pull/16077

Update a local copy of the PR:
$ git checkout pull/16077
$ git pull https://git.openjdk.org/jdk.git pull/16077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16077

View PR using the GUI difftool:
$ git pr show -t 16077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16077.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2023

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@kevinjwalls The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 6, 2023
@kevinjwalls kevinjwalls marked this pull request as ready for review October 9, 2023 09:28
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2023

Webrevs

@kevinjwalls kevinjwalls marked this pull request as draft October 9, 2023 12:09
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 9, 2023
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Placed a couple of nits.
Thanks,
Serguei

}
} catch (URISyntaxException | MonitorException e) {
// ok. process probably not running
takeNap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'm thinking if moving this after line 197 would be more clear.

@kevinjwalls
Copy link
Contributor Author

Eventually I did reproduce a further failure with these test changes, where hasMainArgs is the issue.
For a valid test pid, we got the main args, and they did not match, but we know they SHOULD have due to the additional logging.

MonitoredVmUtil.mainArgs(target) can return "Unknown" or null, so we need to handle this, and not presume that the PID is NOT a test process. We should retry the main args fetch if (monitoredArgs == null || monitoredArgs.equals("Unknown"))

Also, takeNap and the 100ms delay:
This can thrash and just fill logs with 10,000 lines of messages when failing.
Maybe it was short to reduce latency, but that does not seem criticial. Make it longer.

@kevinjwalls kevinjwalls marked this pull request as ready for review October 20, 2023 13:26
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8209595: MonitorVmStartTerminate.java timed out

Reviewed-by: sspitsyn, cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 8065233: 8318598: FFM stylistic cleanups
  • b1228de: 8314588: gc/metaspace/TestMetaspaceInitialization.java failed "assert(capacity_until_gc >= committed_bytes) failed: capacity_until_gc: 3145728 < committed_bytes: 3211264"
  • 5a97411: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics
  • 9144287: 8318601: Remove javadoc text about restricted methods
  • 4010642: 8077371: Binary files in JAXP test should be removed
  • fe52917: 8318457: Use prefix-less prepend methods directly to reduce branches in String concat expressions
  • 71c99a0: 8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913
  • 2c23391: 8318101: Additional test cases for CSSAttributeEqualityBug
  • deadb9c: 8304684: Memory leak in DirectivesParser::set_option_flag
  • a03767c: 8318049: C2: assert(!failure) failed: Missed optimization opportunity in PhaseIterGVN
  • ... and 25 more: https://git.openjdk.org/jdk/compare/47bb1a1cefa242c39c22a8f2aa08d7d357c260b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2023
@kevinjwalls
Copy link
Contributor Author

Thanks for the updated approvals, let's get this integrated...

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

Going to push as commit a045258.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 2121575: 8318421: AbstractPipeline.sourceStageSpliterator() chases pointers needlessly
  • 200b5a2: 8318420: AbstractPipeline invokes overridden method in constructor
  • 5281499: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27
  • 8065233: 8318598: FFM stylistic cleanups
  • b1228de: 8314588: gc/metaspace/TestMetaspaceInitialization.java failed "assert(capacity_until_gc >= committed_bytes) failed: capacity_until_gc: 3145728 < committed_bytes: 3211264"
  • 5a97411: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics
  • 9144287: 8318601: Remove javadoc text about restricted methods
  • 4010642: 8077371: Binary files in JAXP test should be removed
  • fe52917: 8318457: Use prefix-less prepend methods directly to reduce branches in String concat expressions
  • 71c99a0: 8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-8259913
  • ... and 28 more: https://git.openjdk.org/jdk/compare/47bb1a1cefa242c39c22a8f2aa08d7d357c260b9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2023
@openjdk openjdk bot closed this Oct 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@kevinjwalls Pushed as commit a045258.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants