Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags #16080

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Oct 6, 2023

The test uses specific classpath, and jar and is intended to test modules. So I marked is as flagless,


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16080/head:pull/16080
$ git checkout pull/16080

Update a local copy of the PR:
$ git checkout pull/16080
$ git pull https://git.openjdk.org/jdk.git pull/16080/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16080

View PR using the GUI difftool:
$ git pr show -t 16080

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16080.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@lmesnik The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Oct 6, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2023

Webrevs

@lmesnik
Copy link
Member Author

lmesnik commented Oct 6, 2023

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@lmesnik
The core-libs label was successfully removed.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2023
@lmesnik
Copy link
Member Author

lmesnik commented Oct 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

Going to push as commit fec1d49.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 2b8276a: 8316691: Heap dump: separate stack traces for mounted virtual threads
  • 33591a3: 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements
  • fb4098f: 8317730: Change byte_size to return size_t
  • c2abf12: 8261894: Remove support for UseSHM
  • ad7a8e8: 8315505: CompileTask timestamp printed can overflow
  • fcff222: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux
  • ef41aa0: 8317711: Exclude gtest/GTestWrapper.java on AIX
  • ad6dce3: 8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691
  • e882718: 8314199: Initial size PBEKeyFactory#validTypes is not up-to-date
  • d313915: 8316233: VirtualThreadStart events should not be thread-filtered
  • ... and 17 more: https://git.openjdk.org/jdk/compare/6c6beba2569a2f9f3fd5d6988360ffd8680de821...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2023
@openjdk openjdk bot closed this Oct 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@lmesnik Pushed as commit fec1d49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants