JDK-8317693: Unused parameter to Tokens.Token.comment method

[jonathan-gibbons]

Please review a simple cleanup to eliminate an unused parameter and rename the enclosing method.

No new tests; bug is primarily noreg-cleanup. Two tests were affected by the change, but are not in themselves tests for the change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317693: Unused parameter to Tokens.Token.comment method (Bug - P4)

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16088/head:pull/16088
$ git checkout pull/16088

Update a local copy of the PR:
$ git checkout pull/16088
$ git pull https://git.openjdk.org/jdk.git pull/16088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16088

View PR using the GUI difftool:
$ git pr show -t 16088

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16088.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons The following labels will be automatically applied to this pull request:

• compiler
• javadoc
• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (33d50e72)

[irisclark]

Nice clean-up.

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317693: Unused parameter to Tokens.Token.comment method

Reviewed-by: iris, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• bcc986b: 8317601: Windows build on WSL broken after JDK-8317340
• 460ebcd: 8314978: Multiple server call from connection failing with expect100 in getOutputStream

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

Makes sense to me.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit 3ff5a78.
Since your change was applied there have been 9 commits pushed to the master branch:

• 508fa71: 8317736: Stream::handleReset locks twice
• 1f06325: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values
• a07a4a3: 8317422: [JVMCI] concurrency issue in MethodData creation
• 7ff1938: 8310727: C2: *_of() methods in PhaseIterGVN should use uint for the node index
• a57ae7e: 8317594: G1: Refactor find_empty_from_idx_reverse
• 6ddbfaa: 8317136: [AIX] Problem List runtime/jni/terminatedThread/TestTerminatedThread.java
• 0cf1a55: 8317440: Lock rank checking fails when code root set is modified with the Servicelock held after JDK-8315503
• bcc986b: 8317601: Windows build on WSL broken after JDK-8317340
• 460ebcd: 8314978: Multiple server call from connection failing with expect100 in getOutputStream

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit 3ff5a78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.