Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements #16094

Closed
wants to merge 9 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Oct 8, 2023

Alternative to #16082

Name                             (unchanged) Cnt  Base   Error   Test   Error  Unit  Change
URLEncodeDecode.testEncodeLatin1           0  15 2,066 ± 0,104  1,899 ± 0,007 ms/op   1,09x (p = 0,000*)
URLEncodeDecode.testEncodeLatin1          75  15 0,934 ± 0,017  0,811 ± 0,014 ms/op   1,15x (p = 0,000*)
URLEncodeDecode.testEncodeLatin1         100  15 0,433 ± 0,060  0,389 ± 0,007 ms/op   1,11x (p = 0,008*)
  * = significant

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16094/head:pull/16094
$ git checkout pull/16094

Update a local copy of the PR:
$ git checkout pull/16094
$ git pull https://git.openjdk.org/jdk.git pull/16094/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16094

View PR using the GUI difftool:
$ git pr show -t 16094

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16094.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2023

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2023

@cl4es The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 8, 2023
@cl4es cl4es mentioned this pull request Oct 9, 2023
3 tasks
Copy link
Contributor

@minborg minborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements.

@cl4es cl4es changed the title Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements Oct 10, 2023
@cl4es cl4es marked this pull request as ready for review October 10, 2023 11:00
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2023

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

test/jdk/java/util/BitSet/ImmutableBitSet.java Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements

Reviewed-by: pminborg, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2023
@cl4es
Copy link
Member Author

cl4es commented Oct 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

Going to push as commit 33591a3.
Since your change was applied there have been 82 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2023
@openjdk openjdk bot closed this Oct 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@cl4es Pushed as commit 33591a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants