Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253034: Update symbol generation to accomodate Git as the SCM #161

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Sep 14, 2020

The symbol generation script assumed Mercurial was being used as the SCM. This should now be updated to Git.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253034: Update symbol generation to accomodate Git as the SCM

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/161/head:pull/161
$ git checkout pull/161

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2020

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 14, 2020
@openjdk
Copy link

openjdk bot commented Sep 14, 2020

@jddarcy The following labels will be automatically applied to this pull request: build compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added build build-dev@openjdk.org compiler compiler-dev@openjdk.org labels Sep 14, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2020

Webrevs

@@ -63,7 +63,7 @@ if [ ! -f symbols ] ; then
exit 1
fi;

if [ "`hg status .`x" != "x" ] ; then
if [ "`git status -s .`x" != "x" ] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion: perhaps you want to use the porcelain format here instead of short? https://git-scm.com/docs/git-status#Documentation/git-status.txt---porcelainltversiongt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @adityamandaleeka, please use git status --porcelain=v1. See the git status documentation for the specification for the output.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityamandaleeka and @edvbld, thanks for the suggestion; I'll update the patch accordingly.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@jddarcy This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253034: Update symbol generation to accomodate Git as the SCM

Reviewed-by: erikj, adityam
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 86 commits pushed to the master branch:

  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
  • 7eb4d4a: 8247909: Improve PrimitiveConversions::cast using C++14
  • fa30241: 8249676: [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
  • ... and 76 more: https://git.openjdk.java.net/jdk/compare/5d2e79e2c38ff79c1d5712aa77d5ac98eef9f97c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 40206822f4d8fb6b1a7e4d6d9c174dd078ba7e50.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2020
@jddarcy
Copy link
Member Author

jddarcy commented Sep 15, 2020

/integrate

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2020
@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@jddarcy Since your change was applied there have been 86 commits pushed to the master branch:

  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
  • 7eb4d4a: 8247909: Improve PrimitiveConversions::cast using C++14
  • fa30241: 8249676: [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
  • ... and 76 more: https://git.openjdk.java.net/jdk/compare/5d2e79e2c38ff79c1d5712aa77d5ac98eef9f97c...master

Your commit was automatically rebased without conflicts.

Pushed as commit fc36328.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the 8253034 branch February 9, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org compiler compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants