-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317751 : ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows #16106
Conversation
…edTest.java & MouseModifiersUnitTest_Standard.java for windows
👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into |
@lawrence-andrew To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label client |
test/jdk/ProblemList.txt
Outdated
@@ -455,6 +455,9 @@ java/awt/MenuBar/TestNoScreenMenuBar.java 8265987 macosx-all | |||
|
|||
java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java 8266283 generic-all | |||
java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java 8257529 windows-x64 | |||
java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.java 8317751 windows-all | |||
java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.java 8317751 windows-all | |||
java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java 8317751 windows-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8317751 is this bug id. You need to reference a DIFFERENT bug id for the problem listing.
@prrace |
Webrevs
|
Fixed the bug id
@lawrence-andrew This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@lawrence-andrew |
/sponsor |
Going to push as commit f40ea51.
Your commit was automatically rebased without conflicts. |
@prrace @lawrence-andrew Pushed as commit f40ea51. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows
@prrace
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16106/head:pull/16106
$ git checkout pull/16106
Update a local copy of the PR:
$ git checkout pull/16106
$ git pull https://git.openjdk.org/jdk.git pull/16106/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16106
View PR using the GUI difftool:
$ git pr show -t 16106
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16106.diff
Webrev
Link to Webrev Comment