Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317751 : ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows #16106

Closed
wants to merge 2 commits into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Oct 9, 2023

ProblemListed ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

@prrace


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16106/head:pull/16106
$ git checkout pull/16106

Update a local copy of the PR:
$ git checkout pull/16106
$ git pull https://git.openjdk.org/jdk.git pull/16106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16106

View PR using the GUI difftool:
$ git pr show -t 16106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16106.diff

Webrev

Link to Webrev Comment

…edTest.java & MouseModifiersUnitTest_Standard.java for windows
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2023

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@lawrence-andrew To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@prrace
Copy link
Contributor

prrace commented Oct 10, 2023

/label client

@@ -455,6 +455,9 @@ java/awt/MenuBar/TestNoScreenMenuBar.java 8265987 macosx-all

java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java 8266283 generic-all
java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java 8257529 windows-x64
java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.java 8317751 windows-all
java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.java 8317751 windows-all
java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java 8317751 windows-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8317751 is this bug id. You need to reference a DIFFERENT bug id for the problem listing.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@prrace
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 10, 2023

Webrevs

Fixed the bug id
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • fec1d49: 8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags
  • 2b8276a: 8316691: Heap dump: separate stack traces for mounted virtual threads
  • 33591a3: 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements
  • fb4098f: 8317730: Change byte_size to return size_t
  • c2abf12: 8261894: Remove support for UseSHM
  • ad7a8e8: 8315505: CompileTask timestamp printed can overflow
  • fcff222: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux
  • ef41aa0: 8317711: Exclude gtest/GTestWrapper.java on AIX
  • ad6dce3: 8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691
  • e882718: 8314199: Initial size PBEKeyFactory#validTypes is not up-to-date
  • ... and 5 more: https://git.openjdk.org/jdk/compare/f61499c73fe03e2e3680d7f58a84183364c5c5ac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2023
@lawrence-andrew
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@lawrence-andrew
Your change (at version 7922813) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented Oct 10, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

Going to push as commit f40ea51.
Since your change was applied there have been 15 commits pushed to the master branch:

  • fec1d49: 8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags
  • 2b8276a: 8316691: Heap dump: separate stack traces for mounted virtual threads
  • 33591a3: 8317795: Add an ImmutableBitSetPredicate variant for bitsets <= 128 elements
  • fb4098f: 8317730: Change byte_size to return size_t
  • c2abf12: 8261894: Remove support for UseSHM
  • ad7a8e8: 8315505: CompileTask timestamp printed can overflow
  • fcff222: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux
  • ef41aa0: 8317711: Exclude gtest/GTestWrapper.java on AIX
  • ad6dce3: 8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691
  • e882718: 8314199: Initial size PBEKeyFactory#validTypes is not up-to-date
  • ... and 5 more: https://git.openjdk.org/jdk/compare/f61499c73fe03e2e3680d7f58a84183364c5c5ac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2023
@openjdk openjdk bot closed this Oct 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@prrace @lawrence-andrew Pushed as commit f40ea51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants