-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317761: Combine two versions of print_statistics() in java.cpp #16110
8317761: Combine two versions of print_statistics() in java.cpp #16110
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
Webrevs
|
src/hotspot/share/runtime/java.cpp
Outdated
print_method_profiling_data(); | ||
if (NOT_PRODUCT(true) PRODUCT_ONLY(PrintMethodData)) { | ||
// TODO: why is this unconditional in non-product builds? | ||
print_method_profiling_data(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be called unconditional always because we have check inside method.
I think the check in product VM is historical. Originally print_method_profiling_data()
was called only in NOT_PRODUCT and later 8037970 add call to PRODUCT under PrintMethodData
check (there was no this flag check inside method).
Then 8042727 added the flag check inside method to avoid unconditional walk class data (I assume in debug VM). This change made the check before call the method in product version redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I removed the if
check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR a slight difference in behavior between product and non-product builds when it comes to -XX:CompileCommand=print,...
command is whether MDOs are printed or not.
I'm fine with aligning all builds flavors include MDOs into -XX:CompileCommand=print,...
output.
Going to push as commit 84b7cc1.
Your commit was automatically rebased without conflicts. |
The non-product version of
print_statistics()
can be compiled in the product build as well, so there's no need to keep two different versions.BTW, for some reason
print_method_profiling_data()
is called unconditionally in non-product builds, but is guarded byPrintMethodData
in product builds. I made the behavior the same as before in this PR. This can probably be cleaned up in a future PR.I verified that:
TimeOopMap
), or the function itself does nothing (e.g., declared asPRODUCT_RETURN
)Testing: tier1, tier2, build-tiers5
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16110/head:pull/16110
$ git checkout pull/16110
Update a local copy of the PR:
$ git checkout pull/16110
$ git pull https://git.openjdk.org/jdk.git pull/16110/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16110
View PR using the GUI difftool:
$ git pr show -t 16110
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16110.diff
Webrev
Link to Webrev Comment