-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317609: Classfile API fails to verify /jdk.jcmd/sun/tools/jstat/Alignment.class #16123
Conversation
👋 Welcome back asotona! A progress list of the required criteria for merging this PR into |
@asotona To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a side note, it seems weird that you need to pass a CHR again for verification instead of reusing the one from Class-File context object. Maybe we can consider moving verify to Class-File object for a new RFE?
Yes, that would be appropriate. |
/label core-libs |
@asotona |
@asotona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 314 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@AlanBateman Thank you! |
/integrate |
Going to push as commit f1e8787.
Your commit was automatically rebased without conflicts. |
JImageValidator has been recently converted to use ClassFile API and original weak validation of class files was replaced with full class verification.
Unfortunately full class verification is too strong as it includes class assignability verification according to class hierarchy resolution.
This patch relaxes class assignability verification from JImageValidator by mocking ClassHierarchyResolver.
Resolution of all classes as interfaces during verification effectively cancels the assignability verification (as interface assignability is not verified).
Please review this pull request.
Thanks,
Adam
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16123/head:pull/16123
$ git checkout pull/16123
Update a local copy of the PR:
$ git checkout pull/16123
$ git pull https://git.openjdk.org/jdk.git pull/16123/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16123
View PR using the GUI difftool:
$ git pr show -t 16123
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16123.diff
Webrev
Link to Webrev Comment