8317837: Leftover FFM implementation-only changes #16128

JornVernee · 2023-10-10T21:41:01Z

Port of miscellaneous leftover implementation-only changes from the panama-foreign repo:

These four related to improving the performance of the internal strlen implementation:

Adding new benchmarks:

Other misc. changes:

Testing: jdk_foreign

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8317837: Leftover FFM implementation-only changes (Enhancement - P3)

Reviewers

Maurizio Cimadamore (@mcimadamore - Reviewer)

Contributors

Maurizio Cimadamore <mcimadamore@openjdk.org>
Per Minborg <pminborg@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16128/head:pull/16128
$ git checkout pull/16128

Update a local copy of the PR:
$ git checkout pull/16128
$ git pull https://git.openjdk.org/jdk.git pull/16128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16128

View PR using the GUI difftool:
$ git pr show -t 16128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16128.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-10-10T21:42:22Z

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into pr/15103 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-10-10T21:57:57Z

@JornVernee The following labels will be automatically applied to this pull request:

build
core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

JornVernee · 2023-10-10T23:14:35Z

/contributor add @mcimadamore
/contributor add @minborg

openjdk · 2023-10-10T23:15:03Z

@JornVernee
Contributor Maurizio Cimadamore <mcimadamore@openjdk.org> successfully added.

openjdk · 2023-10-10T23:15:50Z

@JornVernee
Contributor Per Minborg <pminborg@openjdk.org> successfully added.

openjdk-notifier · 2023-10-12T19:56:03Z

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout FFMImplFollowup
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk · 2023-10-12T19:59:22Z

@JornVernee this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout FFMImplFollowup
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

Reviewed-by: mcimadamore

Reviewed-by: jvernee

Reviewed-by: mcimadamore

Reviewed-by: jvernee

Reviewed-by: pminborg

Reviewed-by: jvernee

Reviewed-by: mcimadamore

Reviewed-by: jvernee

mlbridge · 2023-10-12T20:47:21Z

Webrevs

01: Full - Incremental (cfc31040)
00: Full (b60dbff1)

mcimadamore

Looks good.
It seems like this PR is missing some string optimizations:
https://git.openjdk.org/panama-foreign/pull/875

Reviewed-by: pminborg

JornVernee · 2023-10-13T11:28:45Z

Thanks for the review. I've added the missing patch now

mcimadamore · 2023-10-13T15:02:22Z

This seems to have been missed too? openjdk/panama-foreign#897

mcimadamore · 2023-10-13T15:11:59Z

This seems to have been missed too? openjdk/panama-foreign#897

I also don't see https://git.openjdk.org/panama-foreign/pull/894

Perhaps you are planning a different PR for "style" only changes?

JornVernee · 2023-10-13T16:27:59Z

Yes, both of those are planned for the style-only PR.

openjdk · 2023-10-13T17:14:48Z

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317837: Leftover FFM implementation-only changes

Co-authored-by: Maurizio Cimadamore <mcimadamore@openjdk.org>
Co-authored-by: Per Minborg <pminborg@openjdk.org>
Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

6273ab9: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
7d31146: 8318028: Remove unused class="centered" from FocusCycle.svg
45b7aed: 8317433: Async UL: Only grab lock once when write():ing
266636d: 8315940: ARM32: Move field resolution information out of the cpCache
e490cf9: 8317432: Async UL: Use memcpy instead of strcpy in Message ctr
126f2ac: 8318006: remove unused net related coding
4d90420: 8315026: ProcessHandle implementation listing processes on AIX should use getprocs64
1082c0e: 8317677: Specialize Vtablestubs::entry_for() for VtableBlob
ec310fe: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object
ff0b397: 8317959: Check return values of malloc in native java.base coding
... and 7 more: https://git.openjdk.org/jdk/compare/32ac72c3d35138f5253e4defc948304ac3ea1b53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

JornVernee · 2023-10-13T19:04:42Z

/integrate

openjdk · 2023-10-13T19:05:51Z

Going to push as commit b12c471.
Since your change was applied there have been 18 commits pushed to the master branch:

605c976: 8318039: GHA: Bump macOS and Xcode versions
6273ab9: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
7d31146: 8318028: Remove unused class="centered" from FocusCycle.svg
45b7aed: 8317433: Async UL: Only grab lock once when write():ing
266636d: 8315940: ARM32: Move field resolution information out of the cpCache
e490cf9: 8317432: Async UL: Use memcpy instead of strcpy in Message ctr
126f2ac: 8318006: remove unused net related coding
4d90420: 8315026: ProcessHandle implementation listing processes on AIX should use getprocs64
1082c0e: 8317677: Specialize Vtablestubs::entry_for() for VtableBlob
ec310fe: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object
... and 8 more: https://git.openjdk.org/jdk/compare/32ac72c3d35138f5253e4defc948304ac3ea1b53...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-10-13T19:05:57Z

@JornVernee Pushed as commit b12c471.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Oct 10, 2023

openjdk-notifier bot changed the base branch from pr/15103 to master October 12, 2023 19:55

openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Oct 12, 2023

minborg and others added 14 commits October 12, 2023 22:21

Fix broken link in JavaDoc

499fd32

Reviewed-by: mcimadamore

8313238: Improve the performance of strlen for null-terminated strings

acd7021

Reviewed-by: jvernee

Fix so that heap segments work

86ef888

Reviewed-by: jvernee

Fix test with strcat

787158c

Reviewed-by: jvernee

Improve strlen performance

44ea496

Reviewed-by: mcimadamore

Avoid using StandardCharset in Java code

0742dd8

Reviewed-by: mcimadamore

Add AllocTest benchmark

5e8a852

Reviewed-by: jvernee

Benchmark Java to/from C string conversions

8989614

Reviewed-by: pminborg

8316196: Use hexadecimal form for address outputs in java.lang.foreign

2e62ba7

Reviewed-by: jvernee

Improve exception messages and simplify LayoutPath

143380a

Reviewed-by: jvernee

Fix arithmetic bug in SegmentAllocator

92c7958

Reviewed-by: mcimadamore

adjust misformatted copyright header

32db8a9

8317137: Time out in TestStringEncoding

703ae86

Reviewed-by: jvernee

Do not run a lengthy test on zero machines

b60dbff

Reviewed-by: jvernee

JornVernee force-pushed the FFMImplFollowup branch from 4850103 to b60dbff Compare October 12, 2023 20:39

openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Oct 12, 2023

JornVernee marked this pull request as ready for review October 12, 2023 20:40

openjdk bot added the rfr Pull request is ready for review label Oct 12, 2023

mcimadamore reviewed Oct 13, 2023

View reviewed changes

8315041: Optimize Java to C string conversion by avoiding double copy

cfc3104

Reviewed-by: pminborg

mcimadamore approved these changes Oct 13, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2023

openjdk bot added the integrated Pull request has been integrated label Oct 13, 2023

openjdk bot closed this Oct 13, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2023

JornVernee deleted the FFMImplFollowup branch October 13, 2023 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8317837: Leftover FFM implementation-only changes #16128

8317837: Leftover FFM implementation-only changes #16128

JornVernee commented Oct 10, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Oct 10, 2023

openjdk bot commented Oct 10, 2023

JornVernee commented Oct 10, 2023

openjdk bot commented Oct 10, 2023

openjdk bot commented Oct 10, 2023

openjdk-notifier bot commented Oct 12, 2023

openjdk bot commented Oct 12, 2023

mlbridge bot commented Oct 12, 2023 •

edited

Loading

mcimadamore left a comment

JornVernee commented Oct 13, 2023

mcimadamore commented Oct 13, 2023

mcimadamore commented Oct 13, 2023

JornVernee commented Oct 13, 2023

openjdk bot commented Oct 13, 2023

JornVernee commented Oct 13, 2023

openjdk bot commented Oct 13, 2023

openjdk bot commented Oct 13, 2023

8317837: Leftover FFM implementation-only changes #16128

8317837: Leftover FFM implementation-only changes #16128

Conversation

JornVernee commented Oct 10, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Contributors

Reviewing

Webrev

bridgekeeper bot commented Oct 10, 2023

openjdk bot commented Oct 10, 2023

JornVernee commented Oct 10, 2023

openjdk bot commented Oct 10, 2023

openjdk bot commented Oct 10, 2023

openjdk-notifier bot commented Oct 12, 2023

openjdk bot commented Oct 12, 2023

mlbridge bot commented Oct 12, 2023 • edited Loading

Webrevs

mcimadamore left a comment

Choose a reason for hiding this comment

JornVernee commented Oct 13, 2023

mcimadamore commented Oct 13, 2023

mcimadamore commented Oct 13, 2023

JornVernee commented Oct 13, 2023

openjdk bot commented Oct 13, 2023

JornVernee commented Oct 13, 2023

openjdk bot commented Oct 13, 2023

openjdk bot commented Oct 13, 2023

JornVernee commented Oct 10, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 12, 2023 •

edited

Loading