Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory #16130

Closed
wants to merge 4 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 10, 2023

Change test to use RandomFactory instead of new Random() and convert it to JUnit 5.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16130/head:pull/16130
$ git checkout pull/16130

Update a local copy of the PR:
$ git checkout pull/16130
$ git pull https://git.openjdk.org/jdk.git pull/16130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16130

View PR using the GUI difftool:
$ git pr show -t 16130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16130.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 10, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2023

Webrevs

@bplb
Copy link
Member Author

bplb commented Oct 11, 2023

I should note that it is intentional to retain the looping inside the vlarious @Test methods. The test runs through 2_400_000 values generated by Random so I would expect that supplying the values by a @MethodSource or some such would generate a mammoth amount of output.

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory

Reviewed-by: rgiulietti

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 309 new commits pushed to the master branch:

  • 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
  • b9983c7: 8318961: increase javacserver connection timeout values and max retry attempts
  • a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
  • 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
  • c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns
  • 3934127: 8318709: Improve System.nanoTime performance on Windows
  • 83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • 1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
  • 988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
  • ... and 299 more: https://git.openjdk.org/jdk/compare/1f063251429a3f6fc1d76911ed7802ad3108a546...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2023
@bplb
Copy link
Member Author

bplb commented Oct 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

Going to push as commit 864a876.
Since your change was applied there have been 309 commits pushed to the master branch:

  • 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
  • b9983c7: 8318961: increase javacserver connection timeout values and max retry attempts
  • a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
  • 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
  • c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns
  • 3934127: 8318709: Improve System.nanoTime performance on Windows
  • 83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • 1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
  • 988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
  • ... and 299 more: https://git.openjdk.org/jdk/compare/1f063251429a3f6fc1d76911ed7802ad3108a546...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2023
@openjdk openjdk bot closed this Oct 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@bplb Pushed as commit 864a876.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the TestFloatingDecimal-8313621 branch October 30, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants