8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory

[bplb]

Change test to use RandomFactory instead of new Random() and convert it to JUnit 5.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory (Bug - P5)

Reviewers

• Raffaello Giulietti (@rgiulietti - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16130/head:pull/16130
$ git checkout pull/16130

Update a local copy of the PR:
$ git checkout pull/16130
$ git pull https://git.openjdk.org/jdk.git pull/16130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16130

View PR using the GUI difftool:
$ git pr show -t 16130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16130.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b6e22fca)
• 01: Full - Incremental (3f4fc63d)
• 00: Full (639a2db3)

[bplb]

I should note that it is intentional to retain the looping inside the vlarious @Test methods. The test runs through 2_400_000 values generated by Random so I would expect that supplying the values by a @MethodSource or some such would generate a mammoth amount of output.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory

Reviewed-by: rgiulietti

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 309 new commits pushed to the master branch:

• 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
• b9983c7: 8318961: increase javacserver connection timeout values and max retry attempts
• a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
• 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
• c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns
• 3934127: 8318709: Improve System.nanoTime performance on Windows
• 83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
• 1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
• 988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
• ... and 299 more: https://git.openjdk.org/jdk/compare/1f063251429a3f6fc1d76911ed7802ad3108a546...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 864a876.
Since your change was applied there have been 309 commits pushed to the master branch:

• 4679e9a: 8310239: Add missing cross modifying fence in nmethod entry barriers
• b9983c7: 8318961: increase javacserver connection timeout values and max retry attempts
• a581897: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• c4c66ab: 8316271: JfrJvmtiAgent::retransformClasses failed: JVMTI_ERROR_FAILS_VERIFICATION
• 88b9cda: 8318981: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with 'disallowed by CompileCommand' missing from stdout/stderr
• c9d23c3: 8315532: Compiler Implementation for Unnamed Variables & Patterns
• 3934127: 8318709: Improve System.nanoTime performance on Windows
• 83eb206: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
• 1183b22: 8310978: JFR events SocketReadEvent/SocketWriteEvent for Socket adaptor ops
• 988e1df: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
• ... and 299 more: https://git.openjdk.org/jdk/compare/1f063251429a3f6fc1d76911ed7802ad3108a546...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 864a876.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.