Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317846: Typo in API documentation of classes IdentityHashMap #16132

Closed
wants to merge 6 commits into from
Closed

8317846: Typo in API documentation of classes IdentityHashMap #16132

wants to merge 6 commits into from

Conversation

anupamdev20
Copy link
Contributor

@anupamdev20 anupamdev20 commented Oct 11, 2023

Hello,

I have fixed the typo in the comment for the constructor IdentityHashMap(Map<? extends K,? extends V> m)

before: Constructs a new identity hash map containing the keys-value mappings in the specified map.
after: Constructs a new identity hash map containing the key-value mappings in the specified map.

Please review the change.

Regards,
Anupam


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317846: Typo in API documentation of classes IdentityHashMap (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16132/head:pull/16132
$ git checkout pull/16132

Update a local copy of the PR:
$ git checkout pull/16132
$ git pull https://git.openjdk.org/jdk.git pull/16132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16132

View PR using the GUI difftool:
$ git pr show -t 16132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16132.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back anupamdev20! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

⚠️ @anupamdev20 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@anupamdev20 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 11, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

@anupamdev20
Copy link
Contributor Author

The checks were failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant