8317846: Typo in API documentation of classes IdentityHashMap

[anupamdev20]

Hello,

I have fixed the typo in the comment for the constructor IdentityHashMap(Map<? extends K,? extends V> m)

before: Constructs a new identity hash map containing the keys-value mappings in the specified map.
after: Constructs a new identity hash map containing the key-value mappings in the specified map.

Please review the change.

Regards,
Anupam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8317846: Typo in API documentation of classes IdentityHashMap (Bug - P4)

Reviewers

• Hamlin Li (@Hamlin-Li - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16134/head:pull/16134
$ git checkout pull/16134

Update a local copy of the PR:
$ git checkout pull/16134
$ git pull https://git.openjdk.org/jdk.git pull/16134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16134

View PR using the GUI difftool:
$ git pr show -t 16134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16134.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back anupamdev20! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@anupamdev20 The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (62493559)
• 00: Full (134e8d7f)

[Hamlin-Li]

trivial change, LGTM

[openjdk]

@anupamdev20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317846: Typo in API documentation of classes IdentityHashMap

Reviewed-by: mli, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 821 new commits pushed to the master branch:

• 519ecd3: 8319413: Start of release updates for JDK 23
• 86f9b3f: 8319313: G1: Rename G1EvacFailureInjector appropriately
• a7f6016: 8320370: NMT: Change MallocMemorySnapshot to simplify code.
• 58530f4: 8321223: Implementation of Scoped Values (Second Preview)
• 2f9e70e: 8321001: RISC-V: C2 SignumVF
• de95259: 8316454: JFR break locale settings
• c42535f: 8321470: ThreadLocal.nextHashCode can be static final
• 42bb852: 8321467: MemorySegment.setString(long, String, Charset) throws IAE(Misaligned access)
• c087e91: 8321505: JFR: Update views
• ead4fb1: 8321519: Typo in exception message
• ... and 811 more: https://git.openjdk.org/jdk/compare/3aa4cba17520a488aa4a338a80f573af10d3e657...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Hamlin-Li, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[anupamdev20]

/integrate

[openjdk]

@anupamdev20
Your change (at version 6249355) is now ready to be sponsored by a Committer.

[jaikiran]

Given that the rest of the javadoc in this class uses the term key-value at various places, this indeed looks like a typo.

The change looks good to me.

[jaikiran]

Please update the copyright year on this file to:

Copyright (c) 2000, 2023, Oracle ....

[jaikiran]

/sponsor

[openjdk]

Going to push as commit d4fb308.
Since your change was applied there have been 968 commits pushed to the master branch:

• d786c49: 8322751: ZGC: Fix comments about marking roots
• 5852f3e: 8322027: One XMLStreamException constructor fails to initialize cause
• be0e1c7: 8297573: Parallel: Rename do_oop_nv to do_oop_work in subclasses of OopClosure
• 7c1d481: 8322765: Eliminate -Wparentheses warnings in runtime code
• 518ec97: 8322747: StringTable should be AllStatic
• 32d80e2: 8322772: Clean up code after JDK-8322417
• 19147f3: 8318158: RISC-V: implement roundD/roundF intrinsics
• 2a59243: 8322734: A redundant return in method padWithLen
• 4fc6b0f: 8068958: Timestamp.from(Instant) should throw when conversion is not possible
• 28c82bf: 8322661: Build broken due to missing jvmtiExport.hpp after JDK-8320139
• ... and 958 more: https://git.openjdk.org/jdk/compare/3aa4cba17520a488aa4a338a80f573af10d3e657...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @anupamdev20 Pushed as commit d4fb308.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.