Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317847: Typo in API documentation of class JPopupMenu #16135

Closed
wants to merge 1 commit into from

Conversation

anupamdev20
Copy link
Contributor

@anupamdev20 anupamdev20 commented Oct 11, 2023

Hello,

I have fixed the typo in the comment for the method JPopupMenu.setInvoker(Component invoker)

before: Sets the invoker of this popup menu -- the component in which the popup menu menu is to be displayed.
after: Sets the invoker of this popup menu -- the component in which the popup menu is to be displayed.

Please review the change.

Regards,
Anupam


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317847: Typo in API documentation of class JPopupMenu (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16135/head:pull/16135
$ git checkout pull/16135

Update a local copy of the PR:
$ git checkout pull/16135
$ git pull https://git.openjdk.org/jdk.git pull/16135/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16135

View PR using the GUI difftool:
$ git pr show -t 16135

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16135.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back anupamdev20! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@anupamdev20 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 11, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@anupamdev20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317847: Typo in API documentation of class JPopupMenu

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 8f8c45b: 8315716: RISC-V: implement ChaCha20 intrinsic
  • 8a9c4d5: 8317675: Serial: Move gc/shared/generation to serial folder
  • bcafec5: 8316958: Add test for unstructured locking
  • 731fb4e: 8317797: G1: Remove unimplemented predict_will_fit
  • 7976151: 8313438: [s390x] build broken after JDK-8301996
  • ca96fd3: 8317839: Exclude java/nio/channels/Channels/SocketChannelStreams.java on AIX
  • a9b41da: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 0fd8071: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic"
  • 1161e3d: 8317803: Exclude java/net/Socket/asyncClose/Race.java on AIX
  • e55c482: 8317790: Fix Bug entry for exclusion of runtime/jni/terminatedThread/TestTerminatedThread.java on AIX
  • ... and 1 more: https://git.openjdk.org/jdk/compare/3aa4cba17520a488aa4a338a80f573af10d3e657...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2023
@anupamdev20
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@anupamdev20
Your change (at version 40d3f79) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

Going to push as commit 77fa44f.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 0983b54: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms
  • 64ee3c9: 8317266: Move nmethod::check_all_dependencies to codeCache.cpp and mark it NOT_PRODUCT
  • 32ac72c: 8312522: Implementation of Foreign Function & Memory API
  • 9728e21: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • a8473b7: 8317336: Assertion error thrown during 'this' escape analysis
  • 16fd43c: 8316693: Simplify at-requires checkDockerSupport()
  • c1f698d: 8317956: Make jdk.internal.util.Architecture current architecture final
  • 9355431: 8316426: Optimization for HexFormat.formatHex
  • 32ccf01: 8317772: NMT: Make peak values available in release builds
  • 4c79e7d: 8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping
  • ... and 26 more: https://git.openjdk.org/jdk/compare/3aa4cba17520a488aa4a338a80f573af10d3e657...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2023
@openjdk openjdk bot closed this Oct 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@aivanov-jdk @anupamdev20 Pushed as commit 77fa44f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants