Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317868: Add @sealedGraph to MethodHandleDesc and descendants #16137

Closed
wants to merge 3 commits into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Oct 11, 2023

This PR proposes to add @sealedGraph to MethodHandleDesc and descendants.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317868: Add @sealedGraph to MethodHandleDesc and descendants (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16137/head:pull/16137
$ git checkout pull/16137

Update a local copy of the PR:
$ git checkout pull/16137
$ git pull https://git.openjdk.org/jdk.git pull/16137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16137

View PR using the GUI difftool:
$ git pr show -t 16137

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16137.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 11, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

@minborg
Copy link
Contributor Author

minborg commented Oct 18, 2023

Any reviewers on this very small PR?

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317868: Add @sealedGraph to MethodHandleDesc and descendants

Reviewed-by: jvernee, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

  • ecd25e7: 8318484: Initial version of cdsConfig.hpp
  • a876beb: 8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes
  • 4cf195f: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.
  • af2f4bf: 8318622: ProblemList gc/cslocker/TestCSLocker.java on linux-x64 in Xcomp mode
  • a1a62d9: 8306308: (ch) Writer created by Channels::newWriter may lose data
  • 77b2394: 8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed
  • d3ebb4a: 8317373: Add Telia Root CA v2
  • 66d90d5: 8318107: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
  • 4dfa379: 7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field
  • 158293d: 8316030: Update Libpng to 1.6.40
  • ... and 196 more: https://git.openjdk.org/jdk/compare/460ebcd9cb94867608e22e07092bd1cf33228700...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2023
@minborg
Copy link
Contributor Author

minborg commented Oct 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

Going to push as commit ffadd63.
Since your change was applied there have been 206 commits pushed to the master branch:

  • ecd25e7: 8318484: Initial version of cdsConfig.hpp
  • a876beb: 8316741: BasicStroke.createStrokedShape miter-limits failing on small shapes
  • 4cf195f: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.
  • af2f4bf: 8318622: ProblemList gc/cslocker/TestCSLocker.java on linux-x64 in Xcomp mode
  • a1a62d9: 8306308: (ch) Writer created by Channels::newWriter may lose data
  • 77b2394: 8318482: problemlist compiler/codecache/CheckLargePages.java on Linux-x64 until JDK-8317831 is fixed
  • d3ebb4a: 8317373: Add Telia Root CA v2
  • 66d90d5: 8318107: Un-ProblemList LocaleProvidersRun and CalendarDataRegression
  • 4dfa379: 7061097: [Doc] Inconsistenency between the spec and the implementation for DateFormat.Field
  • 158293d: 8316030: Update Libpng to 1.6.40
  • ... and 196 more: https://git.openjdk.org/jdk/compare/460ebcd9cb94867608e22e07092bd1cf33228700...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 23, 2023
@openjdk openjdk bot closed this Oct 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@minborg Pushed as commit ffadd63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants