Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317886: Add @sealedGraph to ByteBuffer #16142

Closed
wants to merge 1 commit into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Oct 11, 2023

This PR proposed to Add @sealedGraph to ByteBuffer.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317886: Add @sealedGraph to ByteBuffer (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16142/head:pull/16142
$ git checkout pull/16142

Update a local copy of the PR:
$ git checkout pull/16142
$ git pull https://git.openjdk.org/jdk.git pull/16142/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16142

View PR using the GUI difftool:
$ git pr show -t 16142

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16142.diff

Webrev

Link to Webrev Comment

@minborg minborg changed the title Add @sealedGraph to ByteBuffer 8317886: Add @sealedGraph to ByteBuffer Oct 11, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@minborg The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Oct 11, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317886: Add @sealedGraph to ByteBuffer

Reviewed-by: rriggs, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 2d46b29: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage
  • 8f8c45b: 8315716: RISC-V: implement ChaCha20 intrinsic
  • 8a9c4d5: 8317675: Serial: Move gc/shared/generation to serial folder
  • bcafec5: 8316958: Add test for unstructured locking
  • 731fb4e: 8317797: G1: Remove unimplemented predict_will_fit
  • 7976151: 8313438: [s390x] build broken after JDK-8301996

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2023
@AlanBateman
Copy link
Contributor

Would it possible to include an image on how this looks? Asking because Buffer already has sealedGraph so shows the hierarchy. For ByteBuffer then presumably it will just show that MBB extends BB so I'm wondering if it's useful or not.

@minborg
Copy link
Contributor Author

minborg commented Oct 12, 2023

Would it possible to include an image on how this looks? Asking because Buffer already has sealedGraph so shows the hierarchy. For ByteBuffer then presumably it will just show that MBB extends BB so I'm wondering if it's useful or not.

As you say, Buffer already has the tag, and because of that the JavaDoc of the class will include a graph:

image

However, the tag works on a per-class basis and is not transitive. So ByteBuffer will not have a graph even though it and its permitted subclass MBB is rendered for the Buffer class.

@AlanBateman
Copy link
Contributor

However, the tag works on a per-class basis and is not transitive. So ByteBuffer will not have a graph even though it and its permitted subclass MBB is rendered for the Buffer class.

It works well in Buffer as there is a hierarchy to show. It seems a bit confusing to me to have it also show up in the ByteBuffer docs. Have I missed something or what is the reason for doing this?

@minborg
Copy link
Contributor Author

minborg commented Oct 18, 2023

It works well in Buffer as there is a hierarchy to show. It seems a bit confusing to me to have it also show up in the ByteBuffer docs. Have I missed something or what is the reason for doing this?

The idea is to have graphs for every sealed class that has at least one publicly permitted class. ByteBuffer has one permitted public class in the form of MappedByteBuffer.

@minborg
Copy link
Contributor Author

minborg commented Oct 18, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

Going to push as commit 8dd8096.
Since your change was applied there have been 111 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2023
@openjdk openjdk bot closed this Oct 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@minborg Pushed as commit 8dd8096.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
4 participants