Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8317919: pthread_attr_init handle return value and destroy pthread_attr_t object #16147

Closed
wants to merge 2 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 11, 2023

Seems we miss on AIX and Linux the handling of pthread_attr_init return value and sometimes in special cases destroying the related pthread_attr_t object.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317919: pthread_attr_init handle return value and destroy pthread_attr_t object (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16147/head:pull/16147
$ git checkout pull/16147

Update a local copy of the PR:
$ git checkout pull/16147
$ git pull https://git.openjdk.org/jdk.git pull/16147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16147

View PR using the GUI difftool:
$ git pr show -t 16147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16147.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 11, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like pthread_attr_destroy is also missing in SplashCreateThread (src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m and src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c). Also in tests, but that's probably not relevant.

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317919: pthread_attr_init handle return value and destroy pthread_attr_t object

Reviewed-by: mdoerr, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • c1f698d: 8317956: Make jdk.internal.util.Architecture current architecture final
  • 9355431: 8316426: Optimization for HexFormat.formatHex
  • 32ccf01: 8317772: NMT: Make peak values available in release builds
  • 4c79e7d: 8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping
  • 7633a76: 8317998: Temporarily disable malformed control flow assert to reduce noise in testing
  • 00ef9f9: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • 77dc891: 8317963: Serial: Remove unused GenerationIsInReservedClosure
  • d95b548: 8315850: Improve AbstractMap anonymous Iterator classes
  • 424de29: 8317866: replace NET_SocketAvailable
  • 6d6c900: 8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()
  • ... and 12 more: https://git.openjdk.org/jdk/compare/731fb4eea21ab67d90970d7c6107fb0a4fbee9ec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2023
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for finding and fixing.

@MBaesken
Copy link
Member Author

SplashCreateThread

Hi Martin, I saw those 2 places as well, but thought it is not very relevant there because it is called not often.
But should I still add the pthread_attr_destroy calls there ?

@TheRealMDoerr
Copy link
Contributor

I think that would be cleaner.

@MBaesken
Copy link
Member Author

I think that would be cleaner.

Hi Martin, I adjusted the 2 splash screen related places.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MBaesken
Copy link
Member Author

Hi Martin and Lutz, thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

Going to push as commit ec310fe.
Since your change was applied there have been 34 commits pushed to the master branch:

  • ff0b397: 8317959: Check return values of malloc in native java.base coding
  • c88b387: 8317987: C2 recompilations cause high memory footprint
  • 993951b: 8316464: 3 sun/tools tests ignore VM flags
  • 17535c3: 8317818: Combinatorial explosion during 'this' escape analysis
  • 61ce739: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out
  • 77fa44f: 8317847: Typo in API documentation of class JPopupMenu
  • 0983b54: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms
  • 64ee3c9: 8317266: Move nmethod::check_all_dependencies to codeCache.cpp and mark it NOT_PRODUCT
  • 32ac72c: 8312522: Implementation of Foreign Function & Memory API
  • 9728e21: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • ... and 24 more: https://git.openjdk.org/jdk/compare/731fb4eea21ab67d90970d7c6107fb0a4fbee9ec...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2023
@openjdk openjdk bot closed this Oct 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@MBaesken Pushed as commit ec310fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora
Copy link
Member

@MBaesken the splashscreen changes should really have been reviewed by the client team. Hotspot devs don't generally touch that code.

@dholmes-ora
Copy link
Member

Also note that this issue has been raised in the past, regarding the return value of pthread_attr_init but there was no need to make any change on Linux. From the manpage:

POSIX.1-2001 documents an ENOMEM error for pthread_attr_init(); on Linux these functions always succeed (but por‐
       table and future-proof applications should nevertheless handle a possible error return).

It is very unlikely that this would ever change so we have not made such a change in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants