Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl() #16151

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 11, 2023

There's a call to malloc() in Java_sun_nio_fs_AixNativeDispatcher_getmntctl() where we don't check for a potentially NULL return value (i.e. out of memory).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl() (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16151/head:pull/16151
$ git checkout pull/16151

Update a local copy of the PR:
$ git checkout pull/16151
$ git pull https://git.openjdk.org/jdk.git pull/16151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16151

View PR using the GUI difftool:
$ git pr show -t 16151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16151.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Oct 11, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8038244: (fs) Check return value of malloc in Java_sun_nio_fs_AixNativeDispatcher_getmntctl()

Reviewed-by: bpb, vtewari, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • b92de54: 8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751
  • 2a80160: 8314283: Support for NSS tests on aarch64 platforms
  • 3f6d016: 8314896: additional clarifications to reversed() default methods' implementation requirements
  • 2d46b29: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage
  • 8f8c45b: 8315716: RISC-V: implement ChaCha20 intrinsic
  • 8a9c4d5: 8317675: Serial: Move gc/shared/generation to serial folder
  • bcafec5: 8316958: Add test for unstructured locking

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2023
Copy link
Contributor

@vyommani vyommani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@MBaesken
Copy link
Member Author

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

Going to push as commit 6d6c900.
Since your change was applied there have been 12 commits pushed to the master branch:

  • eca6ea4: 8317873: Add @sealedGraph to IllegalFormatException
  • 2edf9c3: 8317763: Follow-up to AVX512 intrinsics for Arrays.sort() PR
  • 839cb19: 8317581: [s390x] Multiple test failure with LockingMode=2
  • 387896f: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
  • 8d2ad2b: 8317977: update problemlist to include MacOS for sun/security/tools/keytool/NssTest.java
  • b92de54: 8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751
  • 2a80160: 8314283: Support for NSS tests on aarch64 platforms
  • 3f6d016: 8314896: additional clarifications to reversed() default methods' implementation requirements
  • 2d46b29: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage
  • 8f8c45b: 8315716: RISC-V: implement ChaCha20 intrinsic
  • ... and 2 more: https://git.openjdk.org/jdk/compare/731fb4eea21ab67d90970d7c6107fb0a4fbee9ec...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2023
@openjdk openjdk bot closed this Oct 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@MBaesken Pushed as commit 6d6c900.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
4 participants