Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751 #16154

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 11, 2023

A trivial fix to merge two ProblemList entries for
java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16154/head:pull/16154
$ git checkout pull/16154

Update a local copy of the PR:
$ git checkout pull/16154
$ git pull https://git.openjdk.org/jdk.git pull/16154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16154

View PR using the GUI difftool:
$ git pr show -t 16154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16154.diff

…_Standard.java fails on macosx-all after JDK-8317751
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review October 11, 2023 16:56
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/integrate auto

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317964: java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Standard.java fails on macosx-all after JDK-8317751

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2a80160: 8314283: Support for NSS tests on aarch64 platforms
  • 3f6d016: 8314896: additional clarifications to reversed() default methods' implementation requirements
  • 2d46b29: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated client client-libs-dev@openjdk.org labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@dcubed-ojdk
The client label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@azvegint - Thanks for the fast review!

@openjdk openjdk bot added the auto label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

Going to push as commit b92de54.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 2a80160: 8314283: Support for NSS tests on aarch64 platforms
  • 3f6d016: 8314896: additional clarifications to reversed() default methods' implementation requirements
  • 2d46b29: 8317874: Add @sealedGraph to StringTemplate.Processor.Linkage

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2023
@openjdk openjdk bot closed this Oct 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@openjdk[bot] Pushed as commit b92de54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8317964 branch October 12, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants