Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317975: [JVMCI] assert(pointee != nullptr) failed: invariant #16158

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Oct 11, 2023

This PR fixes the clearing of a JNI handle help by libjvmci such that it is done at a safepoint. This is achieved by making a VM call to do the clearing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317975: [JVMCI] assert(pointee != nullptr) failed: invariant (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16158/head:pull/16158
$ git checkout pull/16158

Update a local copy of the PR:
$ git checkout pull/16158
$ git pull https://git.openjdk.org/jdk.git pull/16158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16158

View PR using the GUI difftool:
$ git pr show -t 16158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16158.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Oct 11, 2023
@dougxc dougxc marked this pull request as ready for review October 13, 2023 07:57
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317975: [JVMCI] assert(pointee != nullptr) failed: invariant

Reviewed-by: never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

  • 668d4b0: 8318154: Improve stability of WheelModifier.java test
  • a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • a27fc7e: 8317994: Serial: Use SerialHeap in generation
  • 37eb986: 8154846: SwingNode does not resize when content size constraints are changed
  • 37aed6f: 8315362: NMT: summary diff reports threads count incorrectly
  • 1e930db: 8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification
  • 0275efa: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 77d40ce: 8318085: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-aarch64
  • 4ea1b99: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"
  • 01ea1ef: 8305971: NPE in JavacProcessingEnvironment for missing enum constructor body
  • ... and 46 more: https://git.openjdk.org/jdk/compare/b92de54a81a4037a5396509d41de57323212639c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dougxc
Copy link
Member Author

dougxc commented Oct 16, 2023

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

Going to push as commit 7028fb9.
Since your change was applied there have been 57 commits pushed to the master branch:

  • 36993ae: 8316918: Optimize conversions duplicated across phi nodes
  • 668d4b0: 8318154: Improve stability of WheelModifier.java test
  • a36eaf0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • a27fc7e: 8317994: Serial: Use SerialHeap in generation
  • 37eb986: 8154846: SwingNode does not resize when content size constraints are changed
  • 37aed6f: 8315362: NMT: summary diff reports threads count incorrectly
  • 1e930db: 8316585: [REDO] runtime/InvocationTests spend a lot of time on dependency verification
  • 0275efa: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 77d40ce: 8318085: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-aarch64
  • 4ea1b99: 8317262: LockStack::contains(oop) fails "assert(t->is_Java_thread()) failed: incorrect cast to JavaThread"
  • ... and 47 more: https://git.openjdk.org/jdk/compare/b92de54a81a4037a5396509d41de57323212639c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2023
@openjdk openjdk bot closed this Oct 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@dougxc Pushed as commit 7028fb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants