Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8318006: remove unused net related coding #16164

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 12, 2023

JDK-8253119 removed the old socket implementation code but it did leave some unused code behind, it would be good to remove these unused functions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318006: remove unused net related coding (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16164/head:pull/16164
$ git checkout pull/16164

Update a local copy of the PR:
$ git checkout pull/16164
$ git pull https://git.openjdk.org/jdk.git pull/16164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16164

View PR using the GUI difftool:
$ git pr show -t 16164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16164.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 12, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2023

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, I wonder if the list of include files can be pruned as part of this.

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318006: remove unused net related coding

Reviewed-by: alanb, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • ec310fe: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object
  • ff0b397: 8317959: Check return values of malloc in native java.base coding
  • c88b387: 8317987: C2 recompilations cause high memory footprint
  • 993951b: 8316464: 3 sun/tools tests ignore VM flags
  • 17535c3: 8317818: Combinatorial explosion during 'this' escape analysis
  • 61ce739: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out
  • 77fa44f: 8317847: Typo in API documentation of class JPopupMenu
  • 0983b54: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms
  • 64ee3c9: 8317266: Move nmethod::check_all_dependencies to codeCache.cpp and mark it NOT_PRODUCT
  • 32ac72c: 8312522: Implementation of Foreign Function & Memory API
  • ... and 6 more: https://git.openjdk.org/jdk/compare/4c79e7d59caec01b4d2bdae2f7d25f1dd24ffbf6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2023
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MBaesken
Copy link
Member Author

Hi Alan and Lutz , thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

Going to push as commit 126f2ac.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 4d90420: 8315026: ProcessHandle implementation listing processes on AIX should use getprocs64
  • 1082c0e: 8317677: Specialize Vtablestubs::entry_for() for VtableBlob
  • ec310fe: 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object
  • ff0b397: 8317959: Check return values of malloc in native java.base coding
  • c88b387: 8317987: C2 recompilations cause high memory footprint
  • 993951b: 8316464: 3 sun/tools tests ignore VM flags
  • 17535c3: 8317818: Combinatorial explosion during 'this' escape analysis
  • 61ce739: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out
  • 77fa44f: 8317847: Typo in API documentation of class JPopupMenu
  • 0983b54: 8318038: ProblemList runtime/CompressedOops/CompressedClassPointers.java on two platforms
  • ... and 8 more: https://git.openjdk.org/jdk/compare/4c79e7d59caec01b4d2bdae2f7d25f1dd24ffbf6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2023
@openjdk openjdk bot closed this Oct 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@MBaesken Pushed as commit 126f2ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants